fix: React Bootstrap un-revert with fixups #8996
Open
+6,290
−2,523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
force-pushed
the
camd/react-bootstrap-fixups
branch
from
b3c6aa6 to
e75521b
Compare
camd
force-pushed
the
camd/react-bootstrap-fixups
branch
4 times, most recently
from
a93f2cf to
90e3965
Compare
camd
force-pushed
the
camd/react-bootstrap-fixups
branch
2 times, most recently
from
b5072a5 to
8eba2f1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8996 +/- ##
==========================================
- Coverage 77.73% 77.51% -0.22%
==========================================
Files 581 582 +1
Lines 29710 29876 +166
Branches 3577 3664 +87
==========================================
+ Hits 23095 23159 +64
- Misses 6455 6550 +95
- Partials 160 167 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import { Badge, Button, FormGroup, Input } from 'reactstrap'; | ||
| import { Badge, Button, Form } from 'react-bootstrap'; |
There was a problem hiding this comment.
Locally I see some issues with this component.
|
|
||
| ## Overview | ||
|
|
||
| This document tracks differences found between the local development version of Treeherder (<http://localhost:5001>) and the staging version (<https://treeherder.allizom.org>) when comparing the Perfherder interface. |
There was a problem hiding this comment.
Logging in locally is no longer working for http://localhost:5001/
camd
force-pushed
the
camd/react-bootstrap-fixups
branch
from
8eba2f1 to
87b9115
Compare
|
Some observations:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gone over Treeherder, perfherder, Intermittent Failures View and Push Health. They all look good to me. But there is a lot, so I may have missed something.