Various micro optimizations #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
micro-opt
branch
from
828d92c to
e7d5785
Compare
Nothing major, mostly use more direct APIs to bypass safety checks that we can assert aren't needed. e.g. `OBJ_FROZEN_RAW` doesn't bother checking if the VALUE is an immediate, which we know it isn't because we know it's a T_STRING. Or `ENCODING_GET_INLINED` doesn't check if we're dealing with an extended encoding, which in our case we don't need to know.
casperisfine
force-pushed
the
micro-opt
branch
from
e7d5785 to
6365387
Compare
|
Hum, TruffleRuby crashed, I can't make much sense of the crash report though. (FYI @eregon) |
|
Alright, it passed on the retry, so I'm gonna assume it's unrelated. Logs are here: https://github.com/msgpack/msgpack-ruby/actions/runs/11837028381/job/32983173005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing major, mostly use more direct APIs to bypass safety checks that we can assert aren't needed.
e.g.
OBJ_FROZEN_RAWdoesn't bother checking if the VALUE is an immediate, which we know it isn't because we know it's a T_STRING.Or
ENCODING_GET_INLINEDdoesn't check if we're dealing with an extended encoding, which in our case we don't need to know.