-
-
Notifications
You must be signed in to change notification settings - Fork 132
[dialog][alert dialog] Add renderMode
prop to Backdrop
part
#2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/** | ||
* How to render the backdrop when dialogs are nested in the React tree. | ||
* @default 'root' | ||
* @description | ||
* - `root`: Render only one backdrop at the root dialog. | ||
* - `leaf`: Render only one backdrop at the leaf dialog. | ||
* - `always`: Always render the backdrop regardless of nesting. | ||
*/ | ||
renderMode?: 'root' | 'leaf' | 'always'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size reportTotal Size Change: Show 3 more bundle changes@base-ui-components/react parsed: |
Not a huge fan of the prop name. |
@flaviendelangle yeah I don't like it either but it describes whether it doesn't render or not, so what would it be called? |
Signed-off-by: atomiks <[email protected]>
I don't have a very good proposal :/ |
|
Why would you want |
Closes #1477