Skip to content

[all components] Make error messages consistent #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak added the all components Work that is widespread, impact most of the modules label Jun 3, 2025
Copy link

pkg-pr-new bot commented Jun 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@2049

commit: 617c29f

@mui-bot
Copy link

mui-bot commented Jun 3, 2025

Bundle size report

Total Size Change:${\tiny{\color{red}▲}}$+889B(+0.06%) - Total Gzip Change:${\tiny{\color{green}▼}}$-65B(-0.01%)
Files: 41 total (0 added, 0 removed, 36 changed)

Show 36 more bundle changes

@base-ui-components/reactparsed:${\tiny{\color{red}▲}}$+138B(+0.05%) gzip:${\tiny{\color{green}▼}}$-9B(-0.01%)
@base-ui-components/react/context-menuparsed:${\tiny{\color{red}▲}}$+64B(+0.06%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@base-ui-components/react/menuparsed:${\tiny{\color{red}▲}}$+64B(+0.06%) gzip:${\tiny{\color{red}▲}}$+6B(+0.02%)
@base-ui-components/react/toastparsed:${\tiny{\color{red}▲}}$+57B(+0.22%) gzip:${\tiny{\color{red}▲}}$+1B(+0.01%)
@base-ui-components/react/selectparsed:${\tiny{\color{red}▲}}$+53B(+0.05%) gzip:${\tiny{\color{green}▼}}$-30B(-0.08%)
@base-ui-components/react/accordionparsed:${\tiny{\color{red}▲}}$+18B(+0.08%) gzip:${\tiny{\color{green}▼}}$-1B(-0.01%)
@base-ui-components/react/alert-dialogparsed:${\tiny{\color{red}▲}}$+18B(+0.03%) gzip: 0B(0.00%)
@base-ui-components/react/avatarparsed:${\tiny{\color{red}▲}}$+18B(+0.26%) gzip:${\tiny{\color{green}▼}}$-2B(-0.07%)
@base-ui-components/react/checkboxparsed:${\tiny{\color{red}▲}}$+18B(+0.10%) gzip:${\tiny{\color{green}▼}}$-2B(-0.03%)
@base-ui-components/react/checkbox-groupparsed:${\tiny{\color{red}▲}}$+18B(+0.16%) gzip:${\tiny{\color{green}▼}}$-2B(-0.04%)
@base-ui-components/react/collapsibleparsed:${\tiny{\color{red}▲}}$+18B(+0.10%) gzip:${\tiny{\color{green}▼}}$-4B(-0.06%)
@base-ui-components/react/dialogparsed:${\tiny{\color{red}▲}}$+18B(+0.03%) gzip:${\tiny{\color{green}▼}}$-2B(-0.01%)
@base-ui-components/react/fieldparsed:${\tiny{\color{red}▲}}$+18B(+0.13%) gzip:${\tiny{\color{green}▼}}$-1B(-0.02%)
@base-ui-components/react/formparsed:${\tiny{\color{red}▲}}$+18B(+0.31%) gzip:${\tiny{\color{red}▲}}$+4B(+0.16%)
@base-ui-components/react/inputparsed:${\tiny{\color{red}▲}}$+18B(+0.16%) gzip:${\tiny{\color{green}▼}}$-1B(-0.02%)
@base-ui-components/react/menubarparsed:${\tiny{\color{red}▲}}$+18B(+0.09%) gzip: 0B(0.00%)
@base-ui-components/react/navigation-menuparsed:${\tiny{\color{red}▲}}$+18B(+0.02%) gzip:${\tiny{\color{red}▲}}$+4B(+0.01%)
@base-ui-components/react/number-fieldparsed:${\tiny{\color{red}▲}}$+18B(+0.06%) gzip:${\tiny{\color{green}▼}}$-1B(-0.01%)
@base-ui-components/react/popoverparsed:${\tiny{\color{red}▲}}$+18B(+0.02%) gzip:${\tiny{\color{green}▼}}$-4B(-0.01%)
@base-ui-components/react/preview-cardparsed:${\tiny{\color{red}▲}}$+18B(+0.03%) gzip:${\tiny{\color{green}▼}}$-12B(-0.06%)
@base-ui-components/react/radioparsed:${\tiny{\color{red}▲}}$+18B(+0.12%) gzip:${\tiny{\color{green}▼}}$-2B(-0.04%)
@base-ui-components/react/radio-groupparsed:${\tiny{\color{red}▲}}$+18B(+0.09%) gzip:${\tiny{\color{green}▼}}$-3B(-0.04%)
@base-ui-components/react/scroll-areaparsed:${\tiny{\color{red}▲}}$+18B(+0.11%) gzip:${\tiny{\color{green}▼}}$-1B(-0.02%)
@base-ui-components/react/sliderparsed:${\tiny{\color{red}▲}}$+18B(+0.07%) gzip:${\tiny{\color{green}▼}}$-3B(-0.03%)
@base-ui-components/react/switchparsed:${\tiny{\color{red}▲}}$+18B(+0.13%) gzip:${\tiny{\color{green}▼}}$-2B(-0.04%)
@base-ui-components/react/tabsparsed:${\tiny{\color{red}▲}}$+18B(+0.07%) gzip:${\tiny{\color{green}▼}}$-1B(-0.01%)
@base-ui-components/react/toggleparsed:${\tiny{\color{red}▲}}$+18B(+0.20%) gzip:${\tiny{\color{green}▼}}$-1B(-0.03%)
@base-ui-components/react/toggle-groupparsed:${\tiny{\color{red}▲}}$+18B(+0.13%) gzip:${\tiny{\color{green}▼}}$-3B(-0.06%)
@base-ui-components/react/toolbarparsed:${\tiny{\color{red}▲}}$+18B(+0.10%) gzip:${\tiny{\color{green}▼}}$-2B(-0.03%)
@base-ui-components/react/tooltipparsed:${\tiny{\color{red}▲}}$+18B(+0.03%) gzip:${\tiny{\color{green}▼}}$-5B(-0.02%)
Base UI checkboxparsed:${\tiny{\color{red}▲}}$+18B(+0.10%) gzip: 0B(0.00%)
@base-ui-components/react/fieldsetparsed:${\tiny{\color{red}▲}}$+9B(+0.15%) gzip:${\tiny{\color{red}▲}}$+4B(+0.16%)
@base-ui-components/react/meterparsed:${\tiny{\color{red}▲}}$+9B(+0.12%) gzip:${\tiny{\color{green}▼}}$-1B(-0.03%)
@base-ui-components/react/progressparsed:${\tiny{\color{red}▲}}$+9B(+0.12%) gzip:${\tiny{\color{green}▼}}$-1B(-0.03%)
@base-ui-components/react/separatorparsed:${\tiny{\color{red}▲}}$+9B(+0.23%) gzip:${\tiny{\color{red}▲}}$+5B(+0.29%)
@base-ui-components/react/use-renderparsed:${\tiny{\color{red}▲}}$+9B(+0.23%) gzip:${\tiny{\color{red}▲}}$+6B(+0.36%)

Details of bundle changes

Generated by 🚫 dangerJS against 876890c

Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 617c29f
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/683eac71f562bc00085f1500
😎 Deploy Preview https://deploy-preview-2049--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@michaldudak michaldudak force-pushed the error-messages branch 2 times, most recently from 876890c to 617c29f Compare June 3, 2025 08:03
@michaldudak michaldudak merged commit f687f80 into mui:master Jun 4, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all components Work that is widespread, impact most of the modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants