Skip to content

I have refactored the vmhooks to reduce code duplication. Here are th… #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

I have refactored the vmhooks to reduce code duplication. Here are th… #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
222 changes: 79 additions & 143 deletions vmhost/vmhooks/baseOps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,40 +319,6 @@ func (context *VMHooksImpl) GetBlockHash(nonce int64, resultOffset executor.MemP
return 0
}

func getESDTDataFromBlockchainHook(
context *VMHooksImpl,
addressOffset executor.MemPtr,
tokenIDOffset executor.MemPtr,
tokenIDLen executor.MemLength,
nonce int64,
) (*esdt.ESDigitalToken, error) {
metering := context.GetMeteringContext()
blockchain := context.GetBlockchainContext()

gasToUse := metering.GasSchedule().BaseOpsAPICost.GetExternalBalance
err := metering.UseGasBounded(gasToUse)
if err != nil {
return nil, err
}

address, err := context.MemLoad(addressOffset, vmhost.AddressLen)
if err != nil {
return nil, err
}

tokenID, err := context.MemLoad(tokenIDOffset, tokenIDLen)
if err != nil {
return nil, err
}

esdtToken, err := blockchain.GetESDTToken(address, tokenID, uint64(nonce))
if err != nil {
return nil, err
}

return esdtToken, nil
}

// GetESDTBalance VMHooks implementation.
// @autogenerate(VMHooks)
func (context *VMHooksImpl) GetESDTBalance(
Expand All @@ -362,22 +328,16 @@ func (context *VMHooksImpl) GetESDTBalance(
nonce int64,
resultOffset executor.MemPtr,
) int32 {
metering := context.GetMeteringContext()
metering.StartGasTracing(getESDTBalanceName)

esdtData, err := getESDTDataFromBlockchainHook(context, addressOffset, tokenIDOffset, tokenIDLen, nonce)

if err != nil {
context.FailExecution(err)
return -1
}
err = context.MemStore(resultOffset, esdtData.Value.Bytes())
if err != nil {
context.FailExecution(err)
return -1
}
return context.withESDTData(addressOffset, tokenIDOffset, tokenIDLen, nonce, getESDTBalanceName,
func(goContext *VMHooksImpl, esdtData *esdt.ESDigitalToken) int32 {
err := goContext.MemStore(resultOffset, esdtData.Value.Bytes())
if err != nil {
goContext.FailExecution(err)
return -1
}

return int32(len(esdtData.Value.Bytes()))
return int32(len(esdtData.Value.Bytes()))
})
}

// GetESDTNFTNameLength VMHooks implementation.
Expand All @@ -388,21 +348,15 @@ func (context *VMHooksImpl) GetESDTNFTNameLength(
tokenIDLen executor.MemLength,
nonce int64,
) int32 {
metering := context.GetMeteringContext()
metering.StartGasTracing(getESDTNFTNameLengthName)

esdtData, err := getESDTDataFromBlockchainHook(context, addressOffset, tokenIDOffset, tokenIDLen, nonce)

if err != nil {
context.FailExecution(err)
return -1
}
if esdtData == nil || esdtData.TokenMetaData == nil {
FailExecution(context.GetVMHost(), vmhost.ErrNilESDTData)
return 0
}
return context.withESDTData(addressOffset, tokenIDOffset, tokenIDLen, nonce, getESDTNFTNameLengthName,
func(goContext *VMHooksImpl, esdtData *esdt.ESDigitalToken) int32 {
if esdtData == nil || esdtData.TokenMetaData == nil {
FailExecution(goContext.GetVMHost(), vmhost.ErrNilESDTData)
return 0
}

return int32(len(esdtData.TokenMetaData.Name))
return int32(len(esdtData.TokenMetaData.Name))
})
}

// GetESDTNFTAttributeLength VMHooks implementation.
Expand All @@ -413,21 +367,15 @@ func (context *VMHooksImpl) GetESDTNFTAttributeLength(
tokenIDLen executor.MemLength,
nonce int64,
) int32 {
metering := context.GetMeteringContext()
metering.StartGasTracing(getESDTNFTAttributeLengthName)

esdtData, err := getESDTDataFromBlockchainHook(context, addressOffset, tokenIDOffset, tokenIDLen, nonce)

if err != nil {
context.FailExecution(err)
return -1
}
if esdtData == nil || esdtData.TokenMetaData == nil {
FailExecution(context.GetVMHost(), vmhost.ErrNilESDTData)
return 0
}
return context.withESDTData(addressOffset, tokenIDOffset, tokenIDLen, nonce, getESDTNFTAttributeLengthName,
func(goContext *VMHooksImpl, esdtData *esdt.ESDigitalToken) int32 {
if esdtData == nil || esdtData.TokenMetaData == nil {
FailExecution(goContext.GetVMHost(), vmhost.ErrNilESDTData)
return 0
}

return int32(len(esdtData.TokenMetaData.Attributes))
return int32(len(esdtData.TokenMetaData.Attributes))
})
}

// GetESDTNFTURILength VMHooks implementation.
Expand All @@ -438,24 +386,18 @@ func (context *VMHooksImpl) GetESDTNFTURILength(
tokenIDLen executor.MemLength,
nonce int64,
) int32 {
metering := context.GetMeteringContext()
metering.StartGasTracing(getESDTNFTURILengthName)

esdtData, err := getESDTDataFromBlockchainHook(context, addressOffset, tokenIDOffset, tokenIDLen, nonce)

if err != nil {
context.FailExecution(err)
return -1
}
if esdtData == nil || esdtData.TokenMetaData == nil {
FailExecution(context.GetVMHost(), vmhost.ErrNilESDTData)
return 0
}
if len(esdtData.TokenMetaData.URIs) == 0 {
return 0
}
return context.withESDTData(addressOffset, tokenIDOffset, tokenIDLen, nonce, getESDTNFTURILengthName,
func(goContext *VMHooksImpl, esdtData *esdt.ESDigitalToken) int32 {
if esdtData == nil || esdtData.TokenMetaData == nil {
FailExecution(goContext.GetVMHost(), vmhost.ErrNilESDTData)
return 0
}
if len(esdtData.TokenMetaData.URIs) == 0 {
return 0
}

return int32(len(esdtData.TokenMetaData.URIs[0]))
return int32(len(esdtData.TokenMetaData.URIs[0]))
})
}

// GetESDTTokenData VMHooks implementation.
Expand All @@ -474,60 +416,54 @@ func (context *VMHooksImpl) GetESDTTokenData(
royaltiesHandle int32,
urisOffset executor.MemPtr,
) int32 {
managedType := context.GetManagedTypesContext()
metering := context.GetMeteringContext()
metering.StartGasTracing(getESDTTokenDataName)
return context.withESDTData(addressOffset, tokenIDOffset, tokenIDLen, nonce, getESDTTokenDataName,
func(goContext *VMHooksImpl, esdtData *esdt.ESDigitalToken) int32 {
managedType := goContext.GetManagedTypesContext()

esdtData, err := getESDTDataFromBlockchainHook(context, addressOffset, tokenIDOffset, tokenIDLen, nonce)
value := managedType.GetBigIntOrCreate(valueHandle)
value.Set(esdtData.Value)

if err != nil {
context.FailExecution(err)
return -1
}

value := managedType.GetBigIntOrCreate(valueHandle)
value.Set(esdtData.Value)

err = context.MemStore(propertiesOffset, esdtData.Properties)
if err != nil {
context.FailExecution(err)
return -1
}

if esdtData.TokenMetaData != nil {
err = context.MemStore(hashOffset, esdtData.TokenMetaData.Hash)
if err != nil {
context.FailExecution(err)
return -1
}
err = context.MemStore(nameOffset, esdtData.TokenMetaData.Name)
if err != nil {
context.FailExecution(err)
return -1
}
err = context.MemStore(attributesOffset, esdtData.TokenMetaData.Attributes)
if err != nil {
context.FailExecution(err)
return -1
}
err = context.MemStore(creatorOffset, esdtData.TokenMetaData.Creator)
if err != nil {
context.FailExecution(err)
return -1
}

royalties := managedType.GetBigIntOrCreate(royaltiesHandle)
royalties.SetUint64(uint64(esdtData.TokenMetaData.Royalties))

if len(esdtData.TokenMetaData.URIs) > 0 {
err = context.MemStore(urisOffset, esdtData.TokenMetaData.URIs[0])
err := goContext.MemStore(propertiesOffset, esdtData.Properties)
if err != nil {
context.FailExecution(err)
goContext.FailExecution(err)
return -1
}
}
}
return int32(len(esdtData.Value.Bytes()))

if esdtData.TokenMetaData != nil {
err = goContext.MemStore(hashOffset, esdtData.TokenMetaData.Hash)
if err != nil {
goContext.FailExecution(err)
return -1
}
err = goContext.MemStore(nameOffset, esdtData.TokenMetaData.Name)
if err != nil {
goContext.FailExecution(err)
return -1
}
err = goContext.MemStore(attributesOffset, esdtData.TokenMetaData.Attributes)
if err != nil {
goContext.FailExecution(err)
return -1
}
err = goContext.MemStore(creatorOffset, esdtData.TokenMetaData.Creator)
if err != nil {
goContext.FailExecution(err)
return -1
}

royalties := managedType.GetBigIntOrCreate(royaltiesHandle)
royalties.SetUint64(uint64(esdtData.TokenMetaData.Royalties))

if len(esdtData.TokenMetaData.URIs) > 0 {
err = goContext.MemStore(urisOffset, esdtData.TokenMetaData.URIs[0])
if err != nil {
goContext.FailExecution(err)
return -1
}
}
}
return int32(len(esdtData.Value.Bytes()))
})
}

// GetESDTLocalRoles VMHooks implementation.
Expand Down
Loading
Loading