Implement --close #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bikeshed: the |
|
Hm, --close is confusing I think. --one-way is better, but it also is not clear which way, given that the listener could send or receive data. How about something like --recv-only or --send-only? |
|
maybe |
|
Is
|
|
I think --recv-only is nicest. It leaves the door open for --send-only if we ever need it, and can be used on both sides if ever needed. |
This option causes the sending side to not send any data and instead immeditally send an EOF. This can be useful when you are only interested in sending data in one direction. Closes n0-computer#10
src/main.rs
Outdated
| @@ -323,7 +331,11 @@ async fn listen_stdio(args: ListenArgs) -> Result<()> { | |||
| snafu::ensure_whatever!(buf == dumbpipe::HANDSHAKE, "invalid handshake"); | |||
| } | |||
| tracing::info!("forwarding stdin/stdout to {}", remote_node_id); | |||
There was a problem hiding this comment.
maybe update this log line accordingly as well?
There was a problem hiding this comment.
good suggestion, thanks. the latest commit updates this message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option causes the sending side to not send any data and instead immeditally send an EOF. This can be useful when you are only interested in sending data in one direction.
Closes #10