Skip to content

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Oct 15, 2025

Description

These now live in https://github.com/n0-computer/iroh-tickets and will be published as iroh-tickets.

Breaking Changes

  • iroh-base::ticket has been removed

Notes

The 0rtt and transfer examples now use just EndpointIds to connect, and not tickets anymore. Otherwise we end up in a problematic dependency tree. If necessary I can add direct addresses and relay urls to the transfer example again

Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 46add96

@dignifiedquire dignifiedquire added this to the v0.94 milestone Oct 15, 2025
@dignifiedquire dignifiedquire self-assigned this Oct 15, 2025
@n0bot n0bot bot added this to iroh Oct 15, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Oct 15, 2025
Copy link
Contributor

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

Often to use tickets you had to explicitly import iroh-base, since they were not reexported by iroh. So it is not too inconvenient to depend on another crate.

Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a PR n0-computer/chuck#80 to update netsim to use the endpoint ID. However many of those are air gaped and don't have standard discovery mechanics available. The ticked contained direct addr info which was needed for it to work in this environment. Dunno if relay url is needed because they all are configured to the same test spawned one so that should be fine I think.

You can keep re-running this job till it passes with your changes to check:
https://github.com/n0-computer/iroh/actions/runs/18645720236/job/53152491327

@Frando
Copy link
Member

Frando commented Oct 20, 2025

I'd propose to just use https://github.com/n0-computer/iroh-tickets in chuck then, no need to make it use discovery.

@dignifiedquire
Copy link
Contributor Author

I can also add manual passing of ip addrs to the example if that's what we need for chuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

4 participants