Remove deprecated import with from queries

[a-alle]

Description

This PR removes the import WITH from CALL subqueries in both queries and mutations.

Complexity

Complexity: Low

[changeset-bot]

⚠️ No Changeset found

Latest commit: b9bcda0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[neo4j-team-graphql]

Performance Report

No Performance Changes

Show Full Table

name	dbHits	old dbHits	time (ms)	old time (ms)	maxRows
aggregations.TopLevelAggregateWithMultipleFields	7936	7936	57	68	1134
aggregations.NestedAggregation	15407	15407	64	99	2174
aggregations.AggregationWithWhere	10833	10833	42	70	2174
aggregations.AggregationWhereWithinNestedRelationships	20097917	20097917	1982	2070	2008534
aggregations.AggregationWhereWithinNestedConnections	20097917	20097917	1944	2028	2008534
aggregations.InterfacesAggregations	8324	8324	102	125	2080
aggregations.InterfacesAggregationsWithTwoFields	13526	13526	122	141	2080
connections.Connection	12951	12951	60	74	2174
connections.NestedConnection	37705	37705	127	156	4516
cypher-directive-mutation.TopLevelMutationDirective	1135	1135	24	27	1134
cypher-directive.TopLevelSortWithCypher	12961	12961	40	53	2174
cypher-directive.TopLevelConnectionSortWithCypher	12961	12961	57	71	2174
cypher-directive.TopLevelSortWithCypherWithNested	13096	13096	55	77	2174
cypher-directive.TopLevelConnectionSortWithCypherWithNested	13096	13096	90	117	2174
cypher-directive.TopLevelSortWithExpensiveCypher	13735	13725	95	149	2174
cypher-directive.TopLevelConnectionSortWithExpensiveCypher	13266	13266	99	125	2174
fulltext.Fulltext	80	80	42	54	16
fulltext.FulltextWithNestedQuery	516	516	60	85	84
1262.NestedConnectionWhere	8703	8703	50	63	2174
187.QueryWhere	8564	8564	33	43	2154
2871.NestedRelationshipFilter	19789	19632	56	64	4446
batch-create.BatchCreate	3600	3600	81	108	600
connect.createAndConnect	4411	4411	82	109	1134
create.SimpleMutation	6	6	29	33	1
delete.SimpleDelete	19401	19401	652	653	1040
delete.NestedDeleteInUpdate	14688	14688	99	125	2040
update.NestedUpdate	10129	10129	69	73	2002
query.SimpleQuery	3121	3121	23	23	1040
query.SimpleQueryWithRelationship	15031	15031	41	50	2174
query.SimpleQueryWithNestedWhere	8734	8713	49	57	2161
query.Nested	3988	3988	74	95	1040
query.OrFilterOnRelationships	37201	36724	147	181	2171
query.OrFilterOnRelationshipsAndNested	27236	26759	191	223	2171
query.QueryWithNestedIn	14951	14480	51	70	2117
query.DeeplyNestedConnectionWhere	8883	8702	80	84	2174
query.DeeplyNestedWithRelationshipFilters	17693	17357	128	176	1664
query.NestedWithRelationshipSingleFilters	3808	3808	146	216	1134
sorting.SortMultipleTypes	3436	3436	80	99	1040
sorting.SortMultipleTypesWithCypherWithCypher	13321	13321	100	119	2174
sorting.SortOnNestedFields	12951	12951	45	56	2174
sorting.SortDeeplyNestedFields	39785	39785	90	109	4516
sorting.ConnectionWithSort	3271	3271	80	79	1040
unions.SimpleUnionQuery	321	321	56	60	35
unions.SimpleUnionQueryWithMissingFields	293	293	60	60	35
unions.NestedUnion	309975	309975	249	309	33033
unions.NestedUnionWithMissingFields	283949	283949	247	265	33033

Old Schema Generation: 27.258s
Schema Generation: 26.319s
Old Subgraph Schema Generation: 28.256s
Subgraph Schema Generation: 29.779s

[MacondoExpress]

LGMT,
I identified an edge case not addressed by this PR. Specifically, in the file packages/graphql/tests/tck/directives/authorization/arguments/roles-where.test.ts
at line 488, there appears to be a scenario that is only visible when quering unions and selecting a single entity.