Adaptive MAX_JOBS depending on cpu count #724
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adaptively grow MAX_JOBS beyond 10 for systems with a larger number of cores. For example, with a 9950x3d this reduces compile time from 45s to 30s.
|
I'm deliberately not setting it to cpu_count because on curtain systems this will crash the build (maybe bc of small RAM?) so 10 is a conservative setting here to make sure it does not crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptively grow MAX_JOBS beyond 10 for systems with a larger number of cores.
This is purely for convenience, since MAX_JOBS can be set in the environment, but
probably a better default than a single value across all systems.
For example, with a 9950x3d this reduces compile time from 45s to 30s.