[management] remove regex check from validateDomain() #4000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The offending tests are for the following dns records, which are expected to fail: But according to https://www.rfc-editor.org/rfc/rfc2181#section-11 these are valid DNS names and shouldn't result in an error. |
zvpunry
force-pushed
the
zvpunry/validateDomain
branch
2 times, most recently
from
ed852c7 to
e0d2f86
Compare
zvpunry
force-pushed
the
zvpunry/validateDomain
branch
from
67d6102 to
401a45c
Compare
The regex blocked labels that are allowed by rfc1035 like "x", "x1", "x--x" and possibly some more. The regex check was also redundant because it is directly followed by dns.IsDomainName(domain)
After removing too strict checks from validateDomain(), some tests failed because they expected errors for otherwise valid domain names. This removes the offending tests and adds a test for the maximum length of a domain name.
zvpunry
force-pushed
the
zvpunry/validateDomain
branch
from
401a45c to
ab14c11
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex blocked labels that are allowed by rfc1035 like "x", "x1", "x--x" and possibly some more.
The regex check was also redundant because it is directly followed by dns.IsDomainName(domain)
Describe your changes
I only removed the regex check from validateDomain().
This change still requires an update to management/server/nameserver_test.go because it tests for the too strict domain validation.
Issue ticket number and link
#3996
Stack
Checklist