[client] Fix race issues in lazy tests #4181
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes race conditions in lazy connection tests by adding proper synchronization when accessing peer listeners. The changes introduce a thread-safe method to retrieve peer listeners and update test code to use this method instead of directly accessing the internal peers map.
- Adds a
GetPeerListenermethod with proper mutex locking for thread-safe access - Updates test functions to use the new safe accessor method instead of direct map access
- Improves error handling by checking for peer listener existence before use
| if err := trigger(mgr.peers[peerCfg2.PeerConnID].conn.LocalAddr().String()); err != nil { | ||
| listener, exists = mgr.GetPeerListener(peerCfg2.PeerConnID) | ||
| if !exists { | ||
| t.Fatalf("peer listener for peer1 not found") |
There was a problem hiding this comment.
The error message incorrectly refers to 'peer1' but should refer to 'peer2' since this is checking for peerCfg2.PeerConnID.
| t.Fatalf("peer listener for peer1 not found") | |
| t.Fatalf("peer listener for peer2 not found") |
Copilot uses AI. Check for mistakes.
| @@ -33,6 +33,15 @@ func (m MocWGIface) UpdatePeer(string, []netip.Prefix, time.Duration, *net.UDPAd | |||
|
|
|||
| } | |||
|
|
|||
| // Add this method to the Manager struct | |||
There was a problem hiding this comment.
This comment suggests adding the method to the Manager struct, but the method is actually being added to the test file. The comment should clarify that this is a test helper method or be moved to the actual Manager struct implementation.
Copilot uses AI. Check for mistakes.
|
Describe your changes
Fix race issues in lazy tests
Issue ticket number and link
Stack
Checklist