Skip to content

Fixes #17719: User settings for table stripe #19526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented May 16, 2025

Fixes: #17719

Allows user to configure table row stripe effect.

@jeremystretch jeremystretch requested review from a team and jnovinger and removed request for a team May 16, 2025 18:46
@jnovinger
Copy link
Member

Thank you for your interest in contributing to NetBox, however, it appears there is no accepted issue that correlates to this pull request. Before pull requests are opened, we require an accepted issue as per our contributing guide.

It's very important that you not submit a pull request until the relevant issue has been opened and assigned to you. Otherwise, you risk wasting time on work that may ultimately not be needed.

@jnovinger
Copy link
Member

@tobiasge , I've now assigned #17719 to you.

Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In dark mode, with hover effect and row striping both enabled, you can not tell you're hovering over a line with a lighter background.
image
In the above screenshot, I'm hovering over the dmi01-albany-pdu01 line and it looks just like the dmi01-akron-rtr01 line.

@tobiasge tobiasge force-pushed the 17719-table-user-settings branch from a8dc60a to 1f8ef8a Compare May 27, 2025 13:24
@tobiasge tobiasge force-pushed the 17719-table-user-settings branch from 1f8ef8a to 626e421 Compare May 27, 2025 13:28
@tobiasge tobiasge changed the title Fixes #17719: User settings for hover and stripe Fixes #17719: User settings for table stripe May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zebra striping to rows in tables
3 participants