Fixes: #19669 - Add an API endpoint to download image attachments #19950
Conversation
DanSheps
requested review from
a team and
bctiemann
and removed request for
a team
netbox/extras/api/views.py
Outdated
| def download(self, request, pk, *args, **kwargs): | ||
| obj = get_object_or_404(self.queryset, pk=pk) | ||
| # Render and return the elevation as an SVG drawing with the correct content type | ||
| return serve(request, obj.image.path, document_root=settings.MEDIA_ROOT) |
There was a problem hiding this comment.
Is this path construction correct? When I run this I get:
GET /api/extras/image-attachments/1/download/
HTTP 404 Not Found
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept
{
"detail": "“/Users/btman/Development/netbox-community/netbox/netbox/media/Users/btman/Development/netbox-community/netbox/netbox/media/image-attachments/device_27_20240730_212632-51361-scaled.jpg” does not exist"
}
My MEDIA_ROOT is /Users/btman/Development/netbox-community/netbox/netbox/media
It works if I set document_root="/"
There was a problem hiding this comment.
Odd, it did work when I tested it.
There was a problem hiding this comment.
I am going to try and construct a test for this as well. Just need to figure out the best way to do that.
|
We should also consider FR #18396, which concerns front & rear images for device types. The proposed new endpoint serves image attachments, but not image fields in general. What should we do for other images? A consistent approach would be preferable. |
|
Per discussion in maintainers meeting, we will be allowing Token Authentication against the /media/* URL |
Fixes: #19669 - Add an API endpoint to download image attachments