Skip to content

Fixes: #19998 - Add changelog entry when clearing M2M fields #20026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 8, 2025

Conversation

DanSheps
Copy link
Member

@DanSheps DanSheps commented Aug 5, 2025

Fixes: #19998

  • Add check for clearing of M2M fields to generate object_change records

@DanSheps DanSheps requested a review from a team August 5, 2025 20:34
@DanSheps DanSheps self-assigned this Aug 5, 2025
@DanSheps DanSheps requested review from bctiemann and removed request for a team August 5, 2025 20:34
@bctiemann
Copy link
Contributor

@DanSheps I tested this using the repro steps in the bug and the behavior is still unchanged. When I clear the tags from the interface via the API, the second changelog entry is not created.

Copy link
Contributor

@bctiemann bctiemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested -- clearing tags on interface via API does not create the second changelog entry (same behavior as in bug report).

@DanSheps
Copy link
Member Author

DanSheps commented Aug 8, 2025

Hey Brian,

I must have made a change to using isinstance() after I tested as part of code cleanup. Thanks for the catch. Should be good now

@DanSheps DanSheps requested a review from bctiemann August 8, 2025 02:14
@bctiemann bctiemann merged commit 2d495d4 into main Aug 8, 2025
10 checks passed
@bctiemann bctiemann deleted the 19998-fixes-missing-changelog-cleared-tags branch August 8, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No changelogs entry for deleted tags
2 participants