Fix pager ref assignment #419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract ref from pagerProps to avoid conflicts with forwardRef - Handle both forwardRef and pagerProps ref properly using useImperativeHandle - Fix TypeError: Cannot assign to read-only property 'current' on pagerProps ref - Add comprehensive test coverage for ref handling scenarios - Resolves issue netguru#414 The issue occurred when users passed a ref through pagerProps, causing a conflict with the internal ref handling in the Pager component. This fix properly separates the refs and handles both cases.
- Extract ref from pagerProps to avoid conflicts with forwardRef - Handle both forwardRef and pagerProps ref properly using useImperativeHandle - Fix TypeError: Cannot assign to read-only property 'current' on pagerProps ref - Add comprehensive test coverage for ref handling scenarios - Resolves issue netguru#414 The issue occurred when users passed a ref through pagerProps, causing a conflict with the internal ref handling in the Pager component. This fix properly separates the refs and handles both cases.
- Fix unused parameter warnings in mock functions - Add missing 'page' property to mock props - Simplify test cases to focus on ref functionality - Remove complex pagerProps testing that doesn't match component interface
- Import PagerMethods type for proper ref typing - Replace 'any' types with PagerMethods for better type safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves ???
Description
Affected platforms
Test plan/screenshots/videos