Skip to content

chore: remove p-every #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

chore: remove p-every #6586

merged 4 commits into from
Jul 30, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jul 30, 2025

We can achieve this with Promise.all and no longer need a dependency.

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@43081j 43081j requested a review from a team as a code owner July 30, 2025 08:19
@43081j
Copy link
Contributor Author

43081j commented Jul 30, 2025

@mrstork or @serhalp this edge function failure we get across a bunch of PRs right now:

   ❯ node/server/server.test.ts (2 tests | 2 failed) 2968ms
     × Starts a server and serves requests for edge functions 998ms
       → expected 500 to be 200 // Object.is equality
     × Serves edge functions in a monorepo setup 1969ms
       → expected 500 to be 200 // Object.is equality

the hosted serve function looks like this:

export const serve = (
  functions: () => Promise<Record<string, EdgeFunction>>,
) => {
  // ...
}

but the functions we pass in from our tests look like this:

  const declaration = `const functions = {}; const metadata = { functions: {} };`

im guessing the hosted server changed and it gets cached heavily, which is why some builds and people still get passing test runs but others don't

i've shown the change in #6587

We can achieve this with `Promise.all` and no longer need a dependency.
@43081j 43081j force-pushed the tidy-peveryless branch 3 times, most recently from 5f8fbe3 to ad963ba Compare July 30, 2025 08:57
Copy link
Contributor

@mrstork mrstork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mrstork mrstork merged commit e97b2a5 into netlify:main Jul 30, 2025
35 of 36 checks passed
@43081j 43081j deleted the tidy-peveryless branch July 30, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants