Enable to suppress Suspicious dumping error #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' moved to visitors
…st-class callables
added Definition::getDescriptor(), Helpers::entityToString()
|
@dg Hello, could you please comment this pr in any way? |
|
Please try to describe why such objects are dumped, i.e. very simply what the object is and how it is listed in the configuration file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nette/Di introduced warning about suspicious dumping of objects. While i understand the intention, this little warning forces as to rewritte significant amount of value objects that we just pass around. These value objects commonly implements specific interfaces, following pattern of private variable and getters. Even though we could spend time to rewrite everything into PHP 8.4 pattern of
public protected(set) $variableproperties (and hopefully don't run into any more complicated obstacle), I belive that this dev-oriented warning should be possible to suspend by dev.I propose to add a class attribute that would prevent raising up this warning.
I was unable to add any tests as I don't know how to test trigger_error() function, but I am willing to add them if you point me in some direction.