Skip to content

Juniper junos show rsvp interface #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jnicholson56
Copy link
Contributor

I have updated the variables for juniper_junos_show_rsvp_interface to match variables for alcatel_sros/show_router_rsvp_interface where possible.

The cisco_xr equivalent template shows a smaller subset of info compared to these two. The proper cisco XR command does not have a template in the repository.

@jnicholson56 jnicholson56 marked this pull request as ready for review April 5, 2025 18:22
@mjbear
Copy link
Collaborator

mjbear commented Apr 5, 2025

Although this template was first merged into the repo, technically it is a breaking change.

That's sort of beside the fact in a way though since with breaking changes queuing up there will be a major version release around the corner.

@mjbear mjbear added the question label Apr 5, 2025
@jnicholson56
Copy link
Contributor Author

jnicholson56 commented Apr 26, 2025 via email

@mjbear
Copy link
Collaborator

mjbear commented Apr 26, 2025

My juniper templates are new and the chance of someone using them is next to nothing. How would a change in an existing template affect users that may be relying on it?

While I'm not saying the capture group must be RESERVED_BW, I do think the reserved word spelled out is a better choice for clarity.

We all have no clear way of knowing if someone in the community happened to use the RSVP template.

In checking, this template was first merged in after release 7.8.0 and it's only been out there for about three weeks. I hope to let someone else make the call on this, but I can say that whether it is considered a "breaking change" doesn't exclude it from being merged or anything major.

@jnicholson56
Copy link
Contributor Author

jnicholson56 commented Apr 26, 2025 via email

@mjbear mjbear removed the question label Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants