-
Notifications
You must be signed in to change notification settings - Fork 763
Juniper junos show rsvp interface #2095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Juniper junos show rsvp interface #2095
Conversation
Fixing missing yaml line
Although this template was first merged into the repo, technically it is a breaking change. That's sort of beside the fact in a way though since with breaking changes queuing up there will be a major version release around the corner. |
My juniper templates are new and the chance of someone using them is next
to nothing. How would a change in an existing template affect users that
may be relying on it?
…On Sat, Apr 26, 2025, 12:03 Michael Bear ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ntc_templates/templates/juniper_junos_show_rsvp_interface.textfsm
<#2095 (comment)>
:
> Value AVAIL_BW (\S+)
-Value RESERVED_BW (\S+)
+Value RESV_BW (\S+)
@jvanderaa <https://github.com/jvanderaa> @jmcgill298
<https://github.com/jmcgill298> @itdependsnetworks
<https://github.com/itdependsnetworks>
Thoughts on using RESERVED_BW in this Juniper template and [I can] update
the Alcatel template that has RESV_BW?
Thank you! 😅
—
Reply to this email directly, view it on GitHub
<#2095 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AILVUEW3UA77BTB6VZFYUDT23PDADAVCNFSM6AAAAAB2QYJGZSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOJWGMZDAMJXGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
While I'm not saying the capture group must be We all have no clear way of knowing if someone in the community happened to use the RSVP template. In checking, this template was first merged in after release 7.8.0 and it's only been out there for about three weeks. I hope to let someone else make the call on this, but I can say that whether it is considered a "breaking change" doesn't exclude it from being merged or anything major. |
Ahh ok maybe it doesn't matter
…On Sat, Apr 26, 2025, 14:25 Michael Bear ***@***.***> wrote:
*mjbear* left a comment (networktocode/ntc-templates#2095)
<#2095 (comment)>
My juniper templates are new and the chance of someone using them is next
to nothing. How would a change in an existing template affect users that
may be relying on it?
While I'm not saying the capture group must be RESERVED_BW, I do think
the *reserved* word spelled out is a better choice for clarity.
We all have no clear way of knowing if someone in the community happened
to use the RSVP template.
In checking, this template was first merged in after release 7.8.0 and
it's only been out there for about three weeks. *I'll let someone else
make the call on this*, but I can say that whether it is considered a
"breaking change" doesn't exclude it from being merged or anything major.
—
Reply to this email directly, view it on GitHub
<#2095 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AILVUEUSMX4QA3QODJUP7T323PTVNAVCNFSM6AAAAAB2QYJGZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZSGU4TIOJSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I have updated the variables for juniper_junos_show_rsvp_interface to match variables for alcatel_sros/show_router_rsvp_interface where possible.
The cisco_xr equivalent template shows a smaller subset of info compared to these two. The proper cisco XR command does not have a template in the repository.