Improve Huawei VRP display interface #2137
Conversation
…ture of several attributes
evilmonkey19
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa and
mjbear
as code owners
mjbear
changed the title
Huawei VRP: small fixtures and extending capture of several attributes
Co-authored-by: Michael Bear <[email protected]>
Co-authored-by: Michael Bear <[email protected]>
Co-authored-by: Michael Bear <[email protected]>
Co-authored-by: Michael Bear <[email protected]>
| @@ -11,10 +11,10 @@ Value HOLD_TIMER (\d+) | |||
| Value INTERNET_ADDRESS (\S*) | |||
There was a problem hiding this comment.
Hmmm, do we want to standardize normalize some of these capture group names?
INTERNET_ADDRESS >> IP_ADDRESS
Thoughts?
There was a problem hiding this comment.
yeah please. Much better :)
| @@ -11,10 +11,10 @@ Value HOLD_TIMER (\d+) | |||
| Value INTERNET_ADDRESS (\S*) | |||
| Value INTERNET_PROTOCOL (disabled|enabled) | |||
There was a problem hiding this comment.
Regarding INTERNET_PROTOCOL, I'm not sure if there's an existing "status" capture group name or if this one remains as it is.
Thoughts?
There was a problem hiding this comment.
We can change it to internet_status. If doesn't exist it would be a good idea to create it :)
| @@ -11,10 +11,10 @@ Value HOLD_TIMER (\d+) | |||
| Value INTERNET_ADDRESS (\S*) | |||
| Value INTERNET_PROTOCOL (disabled|enabled) | |||
| Value HARDWARE_ADDRESS (\S{4}-\S{4}-\S{4}) | |||
There was a problem hiding this comment.
Normalize?
HARDWARE_ADDRESS >> MAC_ADDRESS
Thoughts?
mjbear
added
question
and removed
changes_requested
mjbear
dismissed
their stale review
Found other items to discuss before approving and merging.
|
This templates was made originally by someone else, but we can improve it with these suggestions 👍 |
Ah, yes, true 🙂
Awesome, thank you! |
No description provided.