Improve Huawei VRP display interface brief #2140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilmonkey19
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa and
mjbear
as code owners
mjbear
changed the title
Huawei VRP: display interface brief
mjbear
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Ah, all of the added/modified lines are simply to match the line but not capture any values.
Avoid capturing none expected values
@evilmonkey19 Based on the above quote, what was being capture that shouldn't have been?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid capturing none expected values