Only refresh data type checkbox on select datatype change. #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @IgorTatarnikov thanks for raising the issue on this, is this working for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #542 by refreshing only the datatype-checkboxes widget rather than the entire screen, so that content of other widgets is not deleted.
Previously the entire tab was recomposed after the datatype checkboxes were changed, meaning that content in all other widgets was lost. Now, only the datatype checkboxes are refreshed. As far as I can tell, to achieve this in textual, the widget has to be entirely removed and then re-initialized.
This PR adds to the tests ensuring that content in non-datatype checkbox widgets is not deleted after opening the display datatype checkbox window. No documentation is needed.