Skip to content

chore(agent): remove obsolete PHP 7.0/7.1 ZEND_MODULE_API_NO usage #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: remove-obsolete-code
Choose a base branch
from

Conversation

hahuja2
Copy link
Contributor

@hahuja2 hahuja2 commented Jun 24, 2025

This PR removes obsolete PHP 7.0/7.1 ZEND_MODULE_API_NO usage from the agent codebase.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jun 24, 2025

Test Suite Status Result
Multiverse 5/8 passing
SOAK 83/85 passing

@hahuja2 hahuja2 added this to the Removing Obsolete Code milestone Jun 24, 2025
@hahuja2 hahuja2 requested review from mfulb and bduranleau-nr June 24, 2025 19:24
@hahuja2 hahuja2 force-pushed the remove-obsolete-code branch from 74efa40 to f12e255 Compare June 24, 2025 21:51
@hahuja2 hahuja2 force-pushed the remove-obsolete-code-01 branch from 5371661 to 29ed52c Compare June 25, 2025 19:31
@hahuja2 hahuja2 force-pushed the remove-obsolete-code-01 branch from 29ed52c to 1ebe77c Compare June 25, 2025 19:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (remove-obsolete-code@a333a7d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
agent/php_call.c 33.33% 4 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             remove-obsolete-code    #1092   +/-   ##
=======================================================
  Coverage                        ?   78.91%           
=======================================================
  Files                           ?      191           
  Lines                           ?    26887           
  Branches                        ?        0           
=======================================================
  Hits                            ?    21219           
  Misses                          ?     5668           
  Partials                        ?        0           
Flag Coverage Δ
agent-for-php-7.3 78.47% <42.85%> (?)
agent-for-php-7.4 78.33% <42.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants