Remove modal header for smart picker dialogs #7036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide the empty modal header which prevents from accessing the close button Cannot use display:none because there's a `display: flex !important` in the Ncmodal component which would override it. This works because the `.modal-header` element has `position: absolute`. TODO: Add prop to NcModal to hide the header Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
force-pushed
the
remove-modal-header
branch
from
cfda6e5 to
e27e8f7
Compare
|
I tried linking with Talk, it works fine 👍 |
marcoambrosini
added
bug
susnux
reviewed
Jun 18, 2025
| // Cannot use display:none because there's a `display: flex !important` in the | ||
| // Ncmodal component which would override it. This works because the | ||
| // `.modal-header` element has `position: absolute`. | ||
| // TODO: Add prop to NcModal to hide the header |
There was a problem hiding this comment.
If this is a dialog then it should use NcDialog and not NcModal which also would fix this issue.
|
The commit message needs to be adjusted to follow conventional commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal header is unused in smartpicker dialogs and prevents using the closing button.
Required for nextcloud/assistant#257