Skip to content

fix(configuration): [reverse proxy] Correct errors in Multiple domains reverse SSL proxy example #11638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(configuration): [reverse proxy] Correct errors in Multiple domains reverse SSL proxy example #11638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin_manual/configuration_server/reverse_proxy_configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ you can set the following parameters inside the :file:`config/config.php`.
'overwriteprotocol' => 'https',
'overwritewebroot' => '/domain.tld/nextcloud',
'overwritecondaddr' => '^10\.0\.0\.1$',
'overwrite.cli.url' => 'https://domain.tld/,
'overwrite.cli.url' => 'https://ssl-proxy.tld/domain.tld/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'overwrite.cli.url' => 'https://ssl-proxy.tld/domain.tld/',
'overwrite.cli.url' => 'https://ssl-proxy.tld/domain.tld/nextcloud',

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the URL used when emails are sent. I'm not sure you want ssl-proxy.tld to be part of that? Actually I would assume exactly the opposite?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how relevant the above example block is nowadays.
The time that someone would actually use a ssl proxy because the certificates are too expensive is long over.
We should probably remove the section because people confuse it with reverse proxies used today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my more elaborated answer: #9466 (comment)

);

.. note:: If you want to use the SSL proxy during installation you have to
Expand Down