feat: split envelopes by time of arrival #11264
Conversation
|
For reactivity: would it make sense to maintain the brackets in Pinia? Brackets relative to current time are probably not reactive. But if we commit the timestamp to Pinia, e.g. at every synchronization, and re-evaluate, it should be fine. |
There was a problem hiding this comment.
There is a problem with an empty view initially. When the app loads there are no envelopes at first. Fetching initial envelopes is handled inside Mailbox.vue which is not rendered as there are no envelopes initially (and no groups as a consequence). As a result, no envelopes will be fetched and rendered until the first background sync hits.
My suggestions:
- Move the sections/groups from
MailboxThread.vueintoMailbox.vue. - Move some of the envelope fetching logic from
Mailbox.vuetoMailboxThread.vue(have a look atmounted(),loadEnvelopes()andprefetchOtherMailboxes()inMailbox.vue).
In any case, you should rebase against latest origin/main soon as I implemented a lot of changes to the sync logic in Mailbox.vue.
GretaD
force-pushed
the
feat/add-byDate-sections
branch
from
6bb373f to
d95f003
Compare
Bump. You have a computed property that depends on time. How does Vue handle this side effect? Is the window for messages in the last hour evaluated again as time passes? |
you are right, the current one is not the ideal solution, i will do what you suggested and commit the timestamp to Pinia. I was focused on fixing the bugs i caused with this feature and didnt pay attention to this part yet. |
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
GretaD
force-pushed
the
feat/add-byDate-sections
branch
from
1ce13ea to
4b56871
Compare
| @@ -161,6 +192,7 @@ export default { | |||
| await this.prefetchOtherMailboxes() | |||
|
|
|||
| this.mainStore.setHasFetchedInitialEnvelopesMutation(true) | |||
| this.mainStore.updateSyncTimestamp() | |||
There was a problem hiding this comment.
This is only occasion the timestamp is updated. This means the view is not reacting and regrouping when you have the app open for a while
How about updating the time stamp at every sync?
| @@ -91,6 +112,10 @@ export default { | |||
| required: false, | |||
| default: false, | |||
| }, | |||
| customEnvelopes: { | |||
There was a problem hiding this comment.
This seems mostly unused? It's read once, but never assigned
| :load-more-button="false" | ||
| :skip-transition="skipListTransition" | ||
| @delete="onDelete" | ||
| @load-more="loadMore" /> |
There was a problem hiding this comment.
Don't forget about the load more button ;)
There was a problem hiding this comment.
we removed them on purpose, if thats what you mean
| startOfLastMonth.setMonth(startOfLastMonth.getMonth() - 1) | ||
|
|
||
| const groups = { | ||
| [t('mail', 'Last hour')]: [], |
There was a problem hiding this comment.
I will suggest a different approach later because I find it a bit weird to use a translate string as key.
fixes #11057
to do