-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix: Fix alignment issues of app password form #53123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/compile |
} | ||
|
||
.row { | ||
#generate-app-token-section { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as you removed the styling for the classes row
and spacing
, please also remove the class from the element.
Signed-off-by: Sandi Cej <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sandicej, thanks for your contribution :)
I think it would be better to just fix the vertical alignment of the button here, without moving the submit button to a new line.
The current with of the table is more than 400px, but I agree with your idea of equalizing the with of the new-app-password-form to it.

That said, what do you think about setting the with of these elements at 900px, like many other other settings elements? Something like this:

I think it would also make sense to create a css variable --settings-width
for this, but that's probably for another pr :)
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Hi @marcoambrosini, thank you for the feedback. I'm fine with the proposed fix.
Please let me know if these points sound reasonable to you. |
Hi @sandicej,
Thanks again :) |
Summary
Set form max-width to 400px for consistency with other settings forms.
Moved "Create new app password" to a new line to align with the styling of other forms.
Before fix:

After fix:

Checklist