-
Notifications
You must be signed in to change notification settings - Fork 31
Enhancement: Add column width setting #1929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
be10905
to
fca84dc
Compare
fca84dc
to
bf5eb16
Compare
I don't think we need frontend tests for this. Unless you meant something else? |
758c157
to
0031e9f
Compare
@enjeck I've added Behat tests to make sure that we able to store value of the new property and fetch it back. PR rebased, conflicts solved, tests added. So, please, review |
8e9e19a
to
54aa82c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left a few comments.
@@ -95,6 +109,12 @@ export default { | |||
type: Boolean, | |||
default: false, | |||
}, | |||
customSettings: { | |||
type: [Object, Array], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, the Array type is when it is empty. Can you correct it so that the type is only Object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will not work as expected then because server responds with []
instead of {}
if width not defined yet.
I had an attempt to return new \stdClass()
to always respond {}
but in this case we can't properly serialize response and there is http 500 error occurs.
In
As a result,
This ensures that modifying |
src/shared/components/ncTable/partials/columnTypePartials/forms/MainForm.vue
Show resolved
Hide resolved
src/shared/components/ncTable/partials/columnTypePartials/forms/MainForm.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks for that! I’ve only reviewed the frontend code and suggested a few small changes. I’ve tested the UI in Firefox and Chromium, and it generally looks good, with just a few minor issues noted in the comments.
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
@silverkszlo I've updated PR according to your suggestions. Min width changed to |
54aa82c
to
b957801
Compare
b957801
to
b4013fb
Compare
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
b4013fb
to
ba6c96b
Compare
This PR adds possibility to configure column width on a table level. Closes #35
🔍 Preview
Configure width:
Column with fixed width:

TODO: