Skip to content

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Jul 27, 2025

Closes #1154 and replaces #1916. This PR contains complete implementation for the both BE and FE sides.

🔍 Preview

nextcloud-readonly-tables-2025-07-31_00.39.34.mp4

🚧 Todo:

  • Tests

@Koc Koc requested review from enjeck and blizzz as code owners July 27, 2025 16:28
@Koc Koc force-pushed the feature/readonly-columns-v2 branch 2 times, most recently from 00fec50 to 2696c27 Compare July 27, 2025 16:35
@Aveyron-RetD
Copy link

1000 thanks

Would it not be possible that in edition mode those columns do appear but they are greyed out and cannot be entered in. By removing them from edition here you might not know what you are editing.

@Koc Koc requested a review from AIlkiv July 28, 2025 14:27
@blizzz blizzz requested a review from marcoambrosini July 29, 2025 13:58
@blizzz blizzz added enhancement New feature or request 3. to review Waiting for reviews labels Jul 29, 2025
@Koc Koc force-pushed the feature/readonly-columns-v2 branch 3 times, most recently from 433c9d5 to e035173 Compare July 30, 2025 22:38
@Koc
Copy link
Contributor Author

Koc commented Jul 30, 2025

@Aveyron-RetD I've updated PR with your suggestion. This approach requires much more changes 😁 . You can observe behavior on the video

@Aveyron-RetD
Copy link

\o/ thanks for all your contributions. Hope they all get merged soon.

@Koc Koc force-pushed the feature/readonly-columns-v2 branch from e035173 to f80d3b4 Compare July 31, 2025 08:03
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from backend side, no blockers, 👍

@JuliaKirschenheuter @enjeck can we have a look on the frontend bits, too?

Copy link
Contributor

@AIlkiv AIlkiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I have a few minor comments.

@Koc Koc force-pushed the feature/readonly-columns-v2 branch 12 times, most recently from 3980bb6 to 1cbd076 Compare August 4, 2025 17:24
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As a follow up task, let's also make sure the read-only values are not editable with inline editing that's currently being added: #364. A few column types already merged as of yesterday: #1719

@enjeck
Copy link
Contributor

enjeck commented Aug 6, 2025

Thanks! As a follow up task, let's also make sure the read-only values are not editable with inline editing that's currently being added: #364. A few column types already merged as of yesterday: #1719

New issue at #1980

@Koc Koc force-pushed the feature/readonly-columns-v2 branch 2 times, most recently from d90df48 to a7420c5 Compare August 15, 2025 14:55
@Koc Koc force-pushed the feature/readonly-columns-v2 branch 2 times, most recently from 74a1798 to bcc2aee Compare August 18, 2025 22:01
@Koc Koc force-pushed the feature/readonly-columns-v2 branch from bcc2aee to 203c23d Compare August 18, 2025 22:02
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @Koc
The only comment I have for now is I would separate the string into "Read only" in the actions menu

@enjeck
Copy link
Contributor

enjeck commented Sep 1, 2025

It would be great to merge this before I get started with #1769. @Koc Do you have time to look at the failing tests soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View feature: set permission per column: "writable" or "read-only"
6 participants