-
Notifications
You must be signed in to change notification settings - Fork 31
Enhancement: add a read-only option to view columns #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
00fec50
to
2696c27
Compare
1000 thanks Would it not be possible that in edition mode those columns do appear but they are greyed out and cannot be entered in. By removing them from edition here you might not know what you are editing. |
433c9d5
to
e035173
Compare
@Aveyron-RetD I've updated PR with your suggestion. This approach requires much more changes 😁 . You can observe behavior on the video |
\o/ thanks for all your contributions. Hope they all get merged soon. |
e035173
to
f80d3b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from backend side, no blockers, 👍
@JuliaKirschenheuter @enjeck can we have a look on the frontend bits, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I have a few minor comments.
3980bb6
to
1cbd076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d90df48
to
a7420c5
Compare
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
74a1798
to
bcc2aee
Compare
…stments) Signed-off-by: Kostiantyn Miakshyn <[email protected]>
bcc2aee
to
203c23d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @Koc
The only comment I have for now is I would separate the string into "Read only" in the actions menu
Closes #1154 and replaces #1916. This PR contains complete implementation for the both BE and FE sides.
🔍 Preview
nextcloud-readonly-tables-2025-07-31_00.39.34.mp4
🚧 Todo: