-
Notifications
You must be signed in to change notification settings - Fork 31
feat: activity support #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: activity support #2002
Conversation
01bac38
to
efc2122
Compare
can you please add import support 🙏? It can helps me a lot for #1801 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is intentional or not, but if you change a column name, the activity log that references the column still uses the old name which can be confusing
efc2122
to
85c62c1
Compare
@enjeck Since we use the activity log to track the object's history, I think we should respect the column name at the time the action was logged |
I agree! |
99bc822
to
48e8f85
Compare
switch ($subjectIdentifier) { | ||
case self::SUBJECT_TABLE_CREATE: | ||
$subject = $ownActivity ? $l->t('You have created a new table {table}'): $l->t('{user} has created a new table {table}'); | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right way to deal with translations with params? I figured it would be something using square brackets e.g [table]
, as described in https://docs.nextcloud.com/server/latest/developer_manual/basics/translations.html#php-backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luka-nextcloud Are you done here? Because from reading #1897, there are some requirements listed there and I wonder if we will be covering them all here
@enjeck In my opinion, we are done for now. The remaining requirement is clean-up schedule (number 5 and 6) which I think should be discussed and done from the activity app. |
Signed-off-by: Luka Trovic <[email protected]>
48e8f85
to
b31e436
Compare
Resolves: #1897