Skip to content

Conversation

luka-nextcloud
Copy link
Contributor

Resolves: #1897

@luka-nextcloud luka-nextcloud marked this pull request as ready for review August 15, 2025 18:27
@Koc
Copy link
Contributor

Koc commented Aug 15, 2025

can you please add import support 🙏? It can helps me a lot for #1801

Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is intentional or not, but if you change a column name, the activity log that references the column still uses the old name which can be confusing

@luka-nextcloud
Copy link
Contributor Author

Not sure if this is intentional or not, but if you change a column name, the activity log that references the column still uses the old name which can be confusing

@enjeck Since we use the activity log to track the object's history, I think we should respect the column name at the time the action was logged

@enjeck
Copy link
Contributor

enjeck commented Aug 26, 2025

@enjeck Since we use the activity log to track the object's history, I think we should respect the column name at the time the action was logged

I agree!

@luka-nextcloud luka-nextcloud force-pushed the activity-support branch 2 times, most recently from 99bc822 to 48e8f85 Compare August 27, 2025 14:54
Comment on lines +209 to +212
switch ($subjectIdentifier) {
case self::SUBJECT_TABLE_CREATE:
$subject = $ownActivity ? $l->t('You have created a new table {table}'): $l->t('{user} has created a new table {table}');
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right way to deal with translations with params? I figured it would be something using square brackets e.g [table], as described in https://docs.nextcloud.com/server/latest/developer_manual/basics/translations.html#php-backend.

Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luka-nextcloud Are you done here? Because from reading #1897, there are some requirements listed there and I wonder if we will be covering them all here

@luka-nextcloud
Copy link
Contributor Author

@luka-nextcloud Are you done here? Because from reading #1897, there are some requirements listed there and I wonder if we will be covering them all here

@enjeck In my opinion, we are done for now. The remaining requirement is clean-up schedule (number 5 and 6) which I think should be discussed and done from the activity app.

Signed-off-by: Luka Trovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity support
3 participants