docker image build irregularly fails due to 403 from nf-test download

[JulianFlesch]

Description of the bug

Using this Dockerfile to build the nf-core tools image (in our github workflows) fails regularly but not always while installing nf-test with a 403 http error code.

This has been reported a while ago with their old url https://code.askimed.com/install/nf-test/
(issue from 2022 at askimed/nf-test/)

Also occurs now when switching to https://get.nf-test.com/ which is documented as their new install method.

#13 [ 8/11] RUN curl -fsSL https://get.nf-test.com/ | bash     && mv nf-test /usr/local/bin     && chmod a+rx /usr/local/bin/nf-test
#13 0.624 curl: (22) The requested URL returned error: 403
#13 ERROR: process "/bin/sh -c curl -fsSL https://get.nf-test.com/ | bash     && mv nf-test /usr/local/bin     && chmod a+rx /usr/local/bin/nf-test" did not complete successfully: exit code: 22
------
 > [ 8/11] RUN curl -fsSL https://get.nf-test.com/ | bash     && mv nf-test /usr/local/bin     && chmod a+rx /usr/local/bin/nf-test:
0.624 curl: (22) The requested URL returned error: 403

Command used and terminal output

# this is being run
$ cd tools/
$ docker build .

# error only occured during github workflow runs
# NOTE: this only runs when manually adding the `workflow_dispatch` hook
$ gh workflow run push_dockerhub_dev.yml

System information

No response

[JulianFlesch]

Back then a recommendation was to try to install from conda, but it might make the image significantly larger.

Edit: The nf-test github also lists instructions to install from source

[mashehu]

does it work if you try it again a few seconds later? we could add a sleep-retry cycle then.

[JulianFlesch]

Yes, for me so far it has always resolved itself 👍

Could it also be the location/ip/fingerprint of some github workflow runners? 🤔

[mashehu]

i would then just add a retry loop instead of going via conda