Fix egregious indentation issues #1620
Conversation
Add some pretier stuff Update .prettierrc.json Update .prettierrc.json Update .prettierrc.json
This reverts commit 4bbd6a2.
sg-writer
added
kind/bug
|
@sg-writer Ready for another look |
| ... certificate ... | ||
| -----END CERTIFICATE----- |
There was a problem hiding this comment.
This should be indented out further so that it matches with the dashes around BEGIN CERTIFICATE. Hard to say in GitHub's editor here, but I think this is right?
| ... certificate ... | |
| -----END CERTIFICATE----- | |
| ... certificate ... | |
| -----END CERTIFICATE----- |
| - actions: | ||
| - type: forward-internal | ||
| config: | ||
| url: https://b.internal |
There was a problem hiding this comment.
If we remove the YAML formatter check, we need to start being careful that we're using spaces for indentation, not tabs. This policy doesn't work if you paste it into a cloud endpoint because of the tabs.
| - name: good email | ||
| expressions: | ||
| - actions.ngrok.oauth.identity.email.endsWith('@ngrok.com') | ||
| - actions.ngrok.oauth.identity.email.endsWith('@ngrok.com') |
There was a problem hiding this comment.
This needs to be indented more.
| - actions.ngrok.oauth.identity.email.endsWith('@ngrok.com') | |
| - actions.ngrok.oauth.identity.email.endsWith('@ngrok.com') |
| - name: OAuth | ||
| actions: | ||
| - type: oauth | ||
| - type: oauth |
There was a problem hiding this comment.
This needs to be indented more, and then so does everything else nested beneath it.
| - type: oauth | |
| - type: oauth |
| - name: bad email | ||
| expressions: | ||
| - !actions.ngrok.oauth.identity.email.endsWith('@ngrok.com') | ||
| - !actions.ngrok.oauth.identity.email.endsWith('@ngrok.com') |
There was a problem hiding this comment.
| - !actions.ngrok.oauth.identity.email.endsWith('@ngrok.com') | |
| - !actions.ngrok.oauth.identity.email.endsWith('@ngrok.com') |
| - type: openid-connect | ||
| config: | ||
| issuer_url: https://accounts.google.com |
There was a problem hiding this comment.
| - type: openid-connect | |
| config: | |
| issuer_url: https://accounts.google.com | |
| - type: openid-connect | |
| config: | |
| issuer_url: https://accounts.google.com |
| - name: Add JWT authentication and rate limiting | ||
| actions: | ||
| - type: rate-limit | ||
| - type: rate-limit |
There was a problem hiding this comment.
| - type: rate-limit | |
| - type: rate-limit |
3 participants
This PR likely doesn't fix all indentation issues in our yaml snippets, but it does clean up the worst of the worst
It also removes pnpm run fmt from package.json because we have no intended formatting logic yet, and I don't want anyone running those commands thinking we endorse whatever they'll do to the repo yet