feat(store): initialized$ #1575
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that we aren't waiting the httpLoader before doing any data mutation, this does create the following error:
Do
We're now waiting for the initialized$ to be triggered, before letting using use the
set()
method.This later also has been transformed to a Promises, letting people be sure the value is set before moving forward (you can see this in the test).
Note
We could surely fix other problem with this logic, but I'd prefer to do small PRs