Skip to content

feat(service): getTranslations #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

rbalet
Copy link
Collaborator

@rbalet rbalet commented Aug 5, 2025

Description

Let us get the translations object from the store

Closes: #1583

@rbalet rbalet requested a review from CodeAndWeb August 5, 2025 09:41
@rbalet rbalet added this to the v17.1 milestone Aug 5, 2025
@CodeAndWeb
Copy link
Member

We should use DeepReadonly<InterpolatableTranslationObject> as return type to prevent users from changing translations.

@kirillgroshkov
Copy link

What is a next step to get this merged?

@CodeAndWeb @rbalet

@rbalet
Copy link
Collaborator Author

rbalet commented Aug 20, 2025

@CodeAndWeb This PR should be safe, would you find time to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing access to translationService.translations
3 participants