New instances and CI cleanup #427

MaximilianAlgehed · 2025-06-10T08:34:08Z

No description provided.

MaximilianAlgehed · 2025-06-11T13:13:28Z

@nick8325 @UlfNorell and @Rewbert I'd like to get some input on the state of the RunCollectDataTypes stuff. I've made a bunch of changes, added a bunch of instances of Arbitrary, and ignored a fair number of both data-types and whole modules for now to get things to build (and run!). If you guys wouldn't mind having a look at the state of this now and maybe trying to add a few more types and modules back in that would be great!

Rewbert · 2025-06-12T12:25:10Z

Looks really nice! I will try to add some instances to get more familiar with it.

@MaximilianAlgehed This PR will stay open for a while, right? Or will we squeeze all our proposed changes into different PRs?

MaximilianAlgehed · 2025-06-12T13:23:34Z

@Rewbert maybe the best thing to do right now is to move the HackingAgenda.md file into an issue and trying to make this PR just the instances stuff so that we at least have that on master?

Rewbert · 2025-06-12T20:15:54Z

Makes sense. I hope to find some time tomorrow to look at more instances :)

Rewbert · 2025-06-13T10:14:34Z

Pushed some silly instance for System.Console. Please see @MaximilianAlgehed

It exports only three types, and it is trivial to derive instances

instance Arbitrary (ArgDescr Int) where
  arbitrary = oneof [ NoArg <$> arbitrary
                    , ReqArg <$> arbitrary <*> arbitrary
                    , OptArg <$> arbitrary <*> arbitrary
                    ]

instance Arbitrary (ArgOrder Int) where
  arbitrary = oneof [ return RequireOrder
                    , return Permute
                    , ReturnInOrder <$> arbitrary
                    ]

instance Arbitrary (OptDescr Int) where
  arbitrary = Option
                <$> arbitrary
                <*> arbitrary
                <*> arbitrary
                <*> arbitrary

But it is very unlikely that anything sensible will be generated. However, anything sensitive will be dependent on some context, which we cannot supply lmao. I am not sure that I am a fan of these instances.

Had a look at System.Posix as well. It exports a buttload of types. I am sure that we can provide instances for some of them, but not all. Some types are e.g. created via CType macros (never used these macros personally before).

MaximilianAlgehed · 2025-06-13T12:18:37Z

These are fine AFAIK, but it would be nice with shrinking and CPP pragmas to make sure the build passes! ;)

Rewbert · 2025-06-13T12:20:22Z

Haha right, I will make sure to fix it.

MaximilianAlgehed · 2025-06-16T13:32:05Z

CI won't trigger because there are conflicts I think.

Rewbert · 2025-06-16T13:33:33Z

Looks like a silly conflict!

Rewbert · 2025-06-16T13:42:59Z

System.Console appears to have been in base since forever, so leaving the CPP out completely will also be just fine. These bounds specify that it should work for every base/GHC version that we support.

.github/workflows/haskell-ci.yml

…sion that supports it. Also shrinking

andreasabel

Thanks for the revision.

Looks like some consequences of base >= 4.14 have not been pushed through yet...

andreasabel · 2025-06-23T14:59:17Z

QuickCheck.cabal

@@ -136,17 +134,6 @@ library
  if !impl(ghc >= 7.4)


This conditional can also be deleted, as ghc >= 7.4 will never be false.

technically, ghc >= 7.4 is false when you're not compiling for ghc?

andreasabel · 2025-06-23T14:59:54Z

QuickCheck.cabal

-  -- Safe Haskell appeared in GHC 7.2, but GHC.Generics isn't safe until 7.4.
-  if impl (ghc < 7.4)
-    cpp-options: -DNO_SAFE_HASKELL
-
  -- random is explicitly Trustworthy since 1.0.1.0
  -- similar constraint for containers
  if impl(ghc >= 7.2)


Make unconditional (and some more below).

So I was confused by this I think when I went over these impl(ghc >= 7.2) is not true if you're running on hugs or another compiler so I think the right thing to do would be to change these to impl(ghc).

andreasabel · 2025-06-23T15:01:29Z

src/Test/QuickCheck/Arbitrary.hs

+import qualified Data.Semigroup as Semigroup
+import Data.Ord
+
+#if MIN_VERSION_base(4,14,0)


Always true, so you can make this unconditional.

andreasabel · 2025-06-23T15:02:14Z

src/Test/QuickCheck/Arbitrary.hs

@@ -1035,6 +1089,158 @@ instance Arbitrary (f a) => Arbitrary (Monoid.Alt f a) where
  arbitrary = fmap Monoid.Alt arbitrary
  shrink = map Monoid.Alt . shrink . Monoid.getAlt
 #endif
+
+#if MIN_VERSION_base(4,9,0)


Always true.

andreasabel · 2025-06-23T15:02:29Z

src/Test/QuickCheck/Arbitrary.hs

+  shrink = map Down . shrink . getDown
+#endif
+
+#if MIN_VERSION_base(4,14,0)


Always true.

MaximilianAlgehed force-pushed the hacking branch from 1dc8463 to 3e3799d Compare June 10, 2025 08:36

MaximilianAlgehed changed the title ~~Hacking~~ New instances and CI cleanup Jun 12, 2025

This was linked to issues Jun 17, 2025

instances for Down from Data.Ord? #347

Open

Arbitrary instance for Data.List.NonEmpty.NonEmpty #411

Open

Arbitrary instance for Data.Semigroup.Arg #414

Open

Arbitrary instance for Natural #425

Open

andreasabel reviewed Jun 18, 2025

View reviewed changes

.github/workflows/haskell-ci.yml Show resolved Hide resolved

andreasabel reviewed Jun 18, 2025

View reviewed changes

.github/workflows/haskell-ci.yml Show resolved Hide resolved

MaximilianAlgehed force-pushed the hacking branch from 6a9edc4 to ed72ec4 Compare June 19, 2025 06:43

UlfNorell and others added 11 commits June 23, 2025 13:40

hacking agenda

27b6ba4

add 9.12.2 and nightly

43c4eaa

no nightly

ed85010

improve cabal file + remove haskell-ci file

ee3fa6d

more notes

9eb8809

notes

d7d78bf

Commit data type collecting thingy.

9ac2325

refactor

82b20cd

remove stack exec because that's probably just me

d692f97

WIP make the hacks a working test

55768e4

wip

8aa9fdb

MaximilianAlgehed and others added 22 commits June 23, 2025 13:40

don't support ancient GHC versions

f2fc44a

some simplifications and additional instances, running out of steam now

5f72a7e

make it work on ghc 8.10.7

d5bcbe9

make it work on ghc 9.12.2

3708a97

stupid bullshit

aa4ac72

4.16 for solo

e515d60

Option stayed around for longer than I thought

af38e6f

put import behind bars

32406b4

fix hugs

0e3e91c

agenda stuff

7b6095a

Some more arbitrary instances

15fcad3

Make it work on hugs

e1db66f

Move to should be fixed later column

b89dcd9

remove the HACKING_AGENDA.md file, moved to issue

94592f3

silly instances for System.Console

823bdec

changed bounds for System.Console to earliest (QC) supported base ver…

136d254

…sion that supports it. Also shrinking

commit, please trigger ci?

318b8ef

Added note on Text.Read

867f921

Data.Functor.Contravariant

10bf64b

Of course make the System.Console generators more general

ee58e14

Cleanup cabal file some more

78d1a62

more cleanup

acab693

MaximilianAlgehed force-pushed the hacking branch from 4e7135c to acab693 Compare June 23, 2025 11:40

andreasabel reviewed Jun 23, 2025

View reviewed changes

MaximilianAlgehed added 2 commits June 23, 2025 17:10

remove some version bounds

19b9388

simplify

1aefd83

New instances and CI cleanup #427

Are you sure you want to change the base?

New instances and CI cleanup #427

Uh oh!

Conversation

MaximilianAlgehed commented Jun 10, 2025

Uh oh!

MaximilianAlgehed commented Jun 11, 2025

Uh oh!

Rewbert commented Jun 12, 2025

Uh oh!

MaximilianAlgehed commented Jun 12, 2025

Uh oh!

Rewbert commented Jun 12, 2025

Uh oh!

Rewbert commented Jun 13, 2025

Uh oh!

MaximilianAlgehed commented Jun 13, 2025

Uh oh!

Rewbert commented Jun 13, 2025

Uh oh!

MaximilianAlgehed commented Jun 16, 2025

Uh oh!

Rewbert commented Jun 16, 2025

Uh oh!

Rewbert commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

andreasabel left a comment

Choose a reason for hiding this comment

Uh oh!

andreasabel Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

MaximilianAlgehed Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

andreasabel Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

MaximilianAlgehed Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

andreasabel Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

andreasabel Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

andreasabel Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!