Skip to content

fixes #1321; lib/bitabs.nim distinguish 0.0 and -0.0 #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2025
Merged

fixes #1321; lib/bitabs.nim distinguish 0.0 and -0.0 #1322

merged 2 commits into from
Jul 25, 2025
+26 −2

Conversation

demotomohiro
Copy link
Collaborator

float values are compared not only with ==, but also with signbit to distinguish 0.0 and -0.0.

@Araq
Copy link
Member

Araq commented Jul 24, 2025

Not bitabs' job. Instead pool.floats needs to be a different table that casts float to uint64.

@Araq Araq merged commit 3f9d378 into nim-lang:master Jul 25, 2025
3 checks passed
@demotomohiro demotomohiro deleted the fix-1321 branch July 25, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demotomohiro @Araq