upgrade serialport package to version 9.x #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippgerbig
changed the title
|
@philippgerbig Thanks for submitting this update! I've been struggling to get this great dmx package to play well with my electron+react project, and i'm confident this will do it. @maintainers Any word on merger? Seems like build error was just a package-lock inconsistency. |
|
@mikeyrayvon If you want, you can try out dmx-ts which is a TypeScript Rewrite of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded serialport to 9.x to make this package work with lts version of node (14.x).
The used api calls of serialport seem to work fine as well with the new version.
I tested the driver
enttec-usb-dmx-prosuccessfully with an enttec pro device.