Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git-pull-or-clone
package withdegit
npm run clean
->npm run build
->npm run demo
CancellationError
bug - https://github.com/node-red/nr-monaco-build/pull/12/files#diff-61f13e532343f2d28cd36b0b83dbfb80bd6e9812522f5ffbbb74a8ba9534807fR99-R116Raised as draft PR until PR from the built dist is merged into NR Main (PR to follow)
Summary
This pull request updates the build and dependency setup for the Monaco editor i18n generation, modernizing the cloning process for localization files and upgrading several dependencies for improved compatibility and maintainability.
Dependency and tooling updates:
git-pull-or-clone
package withdegit
for cloning thevscode-loc
repository, resulting in a faster and cleaner dependency setup ingenerate-monaco-esm-i18n.js
. [1] [2] [3] [4]package.json
, includingcopy-webpack-plugin
,css-loader
,monaco-editor
,monaco-themes
,typedoc
,typescript
, andwebpack
, to their latest versions for improved stability and compatibility.degit
package todevDependencies
and removed unused or replaced dependencies such asgit-pull-or-clone
andinsane
.Documentation:
README.md
to clarify that the Monaco editor will have a theme set and foreign (not just French) menus, reflecting broader i18n support.Versioning:
0.52.0
to0.52.2
inpackage.json
to reflect these changes.