Skip to content

tools: lint typescript files #58256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

tools: lint typescript files #58256

wants to merge 8 commits into from
+1,207 −533

Conversation

Jorgee97
Copy link

closes #55702 by adding typescript-eslint to the linting rules.

Thanks to @avivkeller for this closed PR #55709.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. typings labels May 10, 2025
@avivkeller
Copy link
Member

Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author.

Thanks!

@Jorgee97
Copy link
Author

Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author.

Thanks!

Sorry for not doing that before, TIL about co-authoring commits.

@codecov Codecov
Copy link

codecov bot commented May 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (53944c4) to head (3c29b5b).
Report is 47 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58256      +/-   ##
==========================================
- Coverage   90.21%   90.20%   -0.02%     
==========================================
  Files         635      635              
  Lines      187171   187171              
  Branches    36748    36753       +5     
==========================================
- Hits       168851   168831      -20     
- Misses      11069    11122      +53     
+ Partials     7251     7218      -33

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95
aduh95 reviewed May 10, 2025
View reviewed changes
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66742/

@JakobJingleheimer
Copy link
Member

Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author.
Thanks!

Sorry for not doing that before, TIL about co-authoring commits.

I think in order for co-authorship to work in this repo, you must add the co-author to the first commit (it's currently applied to an intermediary commit, which will get flattened and thus the co-authorship lost).

DanielRosenwasser
DanielRosenwasser reviewed May 28, 2025
View reviewed changes
typings/internalBinding/blob.d.ts
@@ -11,9 +11,11 @@ declare namespace InternalBlobBinding {
}

export interface BlobBinding {
createBlob(sources: Array<Uint8Array | InternalBlobBinding.BlobHandle>, length: number): InternalBlobBinding.BlobHandle;
createBlob(sources: Array<Uint8Array | InternalBlobBinding.BlobHandle>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why break at the parameter?

test/fixtures/source-map/output/source_map_throw_async_stack_trace.mts
*
* blocks */
*
* blocks */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like the idea of linting test files like this is not a good idea - don't you want to have a variety of styles tested?

Jorgee97 and others added 2 commits June 10, 2025 21:43
@Jorgee97 @DanielRosenwasser
Update doc/eslint.config_partial.mjs
0f1d01d 
Co-authored-by: Daniel Rosenwasser <[email protected]>
@Jorgee97 @DanielRosenwasser
Update eslint.config.mjs
eefb52b 
Co-authored-by: Daniel Rosenwasser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@jakebailey jakebailey jakebailey left review comments

@aduh95 aduh95 aduh95 left review comments

@styfle styfle styfle approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tools: lint TypeScript files
9 participants
@Jorgee97 @nodejs-github-bot @avivkeller @JakobJingleheimer @styfle @DanielRosenwasser @jakebailey @aduh95 @marco-ippolito