-
-
Notifications
You must be signed in to change notification settings - Fork 32k
tools: check for std::vector<v8::Local> in lint #58497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Oops, looks like I missed a few instances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I don't think we need this. We can just enable V8_ENABLE_LOCAL_OFF_STACK_CHECK check on v8 that enforces vector not to be used. |
I think we can have both, in case it ends up in a path that we don't actually build/test in the CI. |
This is getting being caught in the CI of this PR BTW (kinda proves my point about "what if the path is not built in the CI"..) |
I think the GitHub actions require manual rebase. @Aditi-1400 can you rebase again? |
1e9a155
to
2632670
Compare
Adds a lint rule to disallow the usage of
std::vector<v8::Local<T>>
.Follow up from the clean up of
std::vector<v8::Local<T>>
we did before.From pull request: #57578: