Skip to content

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #58500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/quic/streams.h
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ class Stream final : public AsyncWrap,
// The headers_ field holds a block of headers that have been received and
// are being buffered for delivery to the JavaScript side.
// TODO(@jasnell): Use v8::Global instead of v8::Local here.
std::vector<v8::Local<v8::Value>> headers_;
v8::LocalVector<v8::Value> headers_;

// The headers_kind_ field indicates the kind of headers that are being
// buffered.
Expand Down
2 changes: 1 addition & 1 deletion test/addons/make-callback/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ void MakeCallback(const v8::FunctionCallbackInfo<v8::Value>& args) {
assert(args[1]->IsFunction() || args[1]->IsString());
auto isolate = args.GetIsolate();
auto recv = args[0].As<v8::Object>();
std::vector<v8::Local<v8::Value>> argv;
v8::LocalVector<v8::Value> argv(isolate);
for (size_t n = 2; n < static_cast<size_t>(args.Length()); n += 1) {
argv.push_back(args[n]);
}
Expand Down
3 changes: 2 additions & 1 deletion test/addons/openssl-providers/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ using v8::Context;
using v8::FunctionCallbackInfo;
using v8::Isolate;
using v8::Local;
using v8::LocalVector;
using v8::Object;
using v8::String;
using v8::Value;
Expand All @@ -26,7 +27,7 @@ int collectProviders(OSSL_PROVIDER* provider, void* cbdata) {

inline void GetProviders(const FunctionCallbackInfo<Value>& args) {
Isolate* isolate = args.GetIsolate();
std::vector<Local<Value>> arr = {};
LocalVector<Value> arr(isolate, 0);
#if OPENSSL_VERSION_MAJOR >= 3
std::vector<OSSL_PROVIDER*> providers;
OSSL_PROVIDER_do_all(nullptr, &collectProviders, &providers);
Expand Down
Loading