lib: validate AbortSignal.timeout delay per its WebIDL definition #58594

himself65 · 2025-06-06T02:54:17Z

codecov · 2025-06-06T03:59:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (b23648e) to head (364be70).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58594      +/-   ##
==========================================
+ Coverage   90.15%   90.16%   +0.01%     
==========================================
  Files         636      636              
  Lines      187891   187899       +8     
  Branches    36879    36888       +9     
==========================================
+ Hits       169386   169413      +27     
+ Misses      11272    11243      -29     
- Partials     7233     7243      +10

Files with missing lines	Coverage Δ
lib/internal/abort_controller.js	`98.29% <100.00%> (+0.02%)`	⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-06-08T02:12:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67324/

nodejs-github-bot · 2025-06-08T04:20:49Z

Commit Queue failed

- Loading data for nodejs/node/pull/58594
✔  Done loading data for nodejs/node/pull/58594
----------------------------------- PR info ------------------------------------
Title      lib: bypass `delay` in AbortSignal.timeout (#58594)
Author     Alex Yang <[email protected]> (@himself65)
Branch     himself65:himself65/2025/06/06/timer -> nodejs:main
Labels     author ready, needs-ci
Commits    1
 - lib: bypass `delay` in AbortSignal.timeout
Committers 1
 - Alex Yang <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58594
Fixes: https://github.com/nodejs/node/issues/58592
Reviewed-By: Jake Yuesong Li <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58594
Fixes: https://github.com/nodejs/node/issues/58592
Reviewed-By: Jake Yuesong Li <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 06 Jun 2025 02:54:17 GMT
   ✔  Approvals: 1
   ✔  - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/58594#pullrequestreview-2907023450
   ✘  This PR needs to wait 118 more hours to land (or 0 hours if there is one more approval)
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2025-06-08T02:12:11Z: https://ci.nodejs.org/job/node-test-pull-request/67324/
- Querying data for job/node-test-pull-request/67324/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/15514793432

panva · 2025-06-08T09:54:48Z

PRs need two reviews to be landable after 48 hours. With one review a 7 day wait period is observed. A passing CI is also required.

nodejs-github-bot · 2025-06-08T09:55:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67328/

panva · 2025-06-08T09:58:10Z

cc @nodejs/web-standards

panva · 2025-06-09T10:40:03Z

I'll take care of the WPT update separately.

himself65 · 2025-06-09T10:41:38Z

thank u

nodejs-github-bot · 2025-06-09T10:44:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67353/

lib/internal/abort_controller.js

nodejs-github-bot · 2025-06-09T11:51:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67355/

panva

Actually, just relaxing this JS validation won't entirely fix the situation.

The rest of the codepath still only supports uint32 and anything bigger has its duration set to 1 instead. I'll look into it.

./node -e 'AbortSignal.timeout(Number.MAX_SAFE_INTEGER)'
(node:51580) TimeoutOverflowWarning: 9007199254740991 does not fit into a 32-bit signed integer.
Timeout duration was set to 1.

Edit: I don't know what it would take for lib/internal/timers.js to support the range (0, Number.MAX_SAFE_INTEGER) in class Timeout.

panva · 2025-06-09T12:36:55Z

cc @nodejs/timers ☝️

himself65 · 2025-06-09T12:40:13Z

I think maybe we should merge this PR first and change setTimeout behavior later. seems to be separate PR?

Just found webidl says setTimeout only supports a signed long int

panva · 2025-06-09T12:45:23Z

I think maybe we should merge this PR first and change setTimeout behavior later. seems to be separate PR?

Right now large values are rejected, after this PR they will be accepted but the timeout will be set to 1 instead, so no, I don't think we should accept the PR as-is.

At best you could change this to the original uint32 but using WebIDL conversion, i.e. convertToInt('delay', delay, 32, opts) but we should also add a note to the documentation that only values up to 2147483647 are accepted.

himself65 · 2025-06-09T12:55:59Z

commit updated.

according to the old code. I think we from only supports uint32 to uint32 + float + loose convert value

lib/internal/abort_controller.js

Co-authored-by: Filip Skokan <[email protected]>

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 6, 2025

himself65 force-pushed the himself65/2025/06/06/timer branch 2 times, most recently from 351dacb to 83f5055 Compare June 6, 2025 03:10

himself65 requested a review from jasnell June 7, 2025 06:57

jakecastelli approved these changes Jun 7, 2025

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 8, 2025

himself65 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2025

panva removed commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 8, 2025

This comment was marked as outdated.

Sign in to view

panva added web-standards Issues and PRs related to Web APIs and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 8, 2025

himself65 changed the title ~~lib: bypass delay in AbortSignal.timeout~~ lib: validate AbortSignal.timeout delay per its WebIDL definition Jun 9, 2025

himself65 force-pushed the himself65/2025/06/06/timer branch 3 times, most recently from 0ca0bbb to 64e4c90 Compare June 9, 2025 09:30

panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025

panva approved these changes Jun 9, 2025

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025

panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 9, 2025

jazelly approved these changes Jun 9, 2025

View reviewed changes

lib/internal/abort_controller.js Show resolved Hide resolved

jakecastelli approved these changes Jun 9, 2025

View reviewed changes

panva removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 9, 2025

panva requested changes Jun 9, 2025

View reviewed changes

lib: validate AbortSignal.timeout delay per its WebIDL definition

70d006a

himself65 force-pushed the himself65/2025/06/06/timer branch from 64e4c90 to 70d006a Compare June 9, 2025 12:52

panva reviewed Jun 9, 2025

View reviewed changes

lib/internal/abort_controller.js Outdated Show resolved Hide resolved

fixup!: update lib/internal/abort_controller.js

364be70

Co-authored-by: Filip Skokan <[email protected]>

himself65 mentioned this pull request Jun 9, 2025

lib: validate AbortSignal.timeout delay per its WebIDL definition #58648

Open

panva added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Jun 9, 2025

Uh oh!

lib: validate AbortSignal.timeout delay per its WebIDL definition #58594

Are you sure you want to change the base?

lib: validate AbortSignal.timeout delay per its WebIDL definition #58594

Conversation

himself65 commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Jun 8, 2025

Uh oh!

nodejs-github-bot commented Jun 8, 2025

Uh oh!

panva commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 8, 2025

Uh oh!

panva commented Jun 8, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

panva commented Jun 9, 2025

Uh oh!

himself65 commented Jun 9, 2025

Uh oh!

nodejs-github-bot commented Jun 9, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 9, 2025

Uh oh!

panva left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

panva commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

himself65 commented Jun 9, 2025

Uh oh!

panva commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

himself65 commented Jun 9, 2025

Uh oh!

Uh oh!

Uh oh!

himself65 commented Jun 6, 2025 •

edited

Loading

codecov bot commented Jun 6, 2025 •

edited

Loading

panva commented Jun 8, 2025 •

edited

Loading

panva left a comment •

edited

Loading

panva commented Jun 9, 2025 •

edited

Loading

panva commented Jun 9, 2025 •

edited

Loading