fs: make Dir disposers idempotent
#58692
Merged
+21
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Ethan-Arrowood
approved these changes
Jun 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58692 +/- ##
==========================================
- Coverage 90.16% 90.14% -0.03%
==========================================
Files 637 637
Lines 188098 188015 -83
Branches 36905 36891 -14
==========================================
- Hits 169601 169478 -123
- Misses 11231 11285 +54
+ Partials 7266 7252 -14
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jun 12, 2025
bjohansebas
approved these changes
Jun 14, 2025
lpinca
approved these changes
Jun 20, 2025
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ce546e4 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 23, 2025
PR-URL: #58692 Refs: #58206 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per draft explicit resource management guidelines (#58526) regarding disposer behaviour.
refs: #58206