process: move multipleResolves event to EOL #58707
Open
+10
−238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
semver-major
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58707 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 640 640
Lines 188287 188225 -62
Branches 36917 36903 -14
=======================================
- Hits 169628 169582 -46
+ Misses 11361 11358 -3
+ Partials 7298 7285 -13
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Not blocking but IMHO this event should get Legacy status rather than being removed. Or we can keep it forever runtime deprecated (similar to how DEP0174 works) and make the warning message more descriptive.
Despite the false positives with Promise.race and Promise.all, it still can be useful for locating problems where code unintentionally keeps flowing after calling resolve() or reject().
If keeping this causes noticeable runtime overhead even when there's no listener (judging from this PR, it's just one boolean check per fired event?), +0 solely for performance reasons.
Ethan-Arrowood
approved these changes
Jun 20, 2025
|
@nodejs/tsc |
RafaelGSS
approved these changes
Jun 21, 2025
jasnell
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58707 ✔ Done loading data for nodejs/node/pull/58707 ----------------------------------- PR info ------------------------------------ Title process: move multipleResolves event to EOL (#58707) Author James M Snell <[email protected]> (@jasnell) Branch jasnell:jasnell/multipleresolves-eol -> nodejs:main Labels semver-major, process, deprecations, needs-ci, commit-queue-squash Commits 2 - process: move multipleResolves event to EOL - Apply suggestions from code review Committers 2 - James M Snell <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58707 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58707 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 14 Jun 2025 21:50:54 GMT ✔ Approvals: 3 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58707#pullrequestreview-2946874060 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58707#pullrequestreview-2947696086 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58707#pullrequestreview-2947784147 ✘ Last GitHub CI failed ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15798026652 |
This comment was marked as outdated.
This comment was marked as outdated.
The `multipleResolves` event has been deprecated for several years now. It's time.
jasnell
force-pushed
the
jasnell/multipleresolves-eol
branch
from
9561a09 to
bb5a924
Compare
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Jun 21, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
BridgeAR
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
multipleResolvesevent has been deprecated for several years now. It's time.