assert,util: fail promise comparison in deep equal checks #59448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
added
the
semver-major
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59448 +/- ##
=======================================
Coverage 89.88% 89.89%
=======================================
Files 656 656
Lines 192947 192984 +37
Branches 37841 37858 +17
=======================================
+ Hits 173427 173474 +47
+ Misses 12054 12052 -2
+ Partials 7466 7458 -8
🚀 New features to boost your workflow:
|
targos
approved these changes
Aug 12, 2025
panva
approved these changes
Aug 12, 2025
BridgeAR
added
request-ci
github-actions
bot
removed
the
request-ci
|
Can this behaviour get a mention under the method descriptions in assert.md, as WeakMap/WeakSet do currently? |
lpinca
approved these changes
Aug 13, 2025
|
There is a typo in commit message "it's state" -> "its state". |
It is impossible to look into the content of a promise and its state. This aligns the comparison with WeakMaps and WeakSets. Only reference equal promises will pass the check in the future. Fixes nodejs#55198
BridgeAR
force-pushed
the
2025-08-11-fail-promise-comparison
branch
from
23edea2 to
74ff4a7
Compare
|
I just updated the docs and fixed the commit message typo. PTAL |
MoLow
approved these changes
Aug 16, 2025
github-actions
bot
removed
the
request-ci
BridgeAR
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7c9fbc1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is impossible to look into the content of a promise and it's state. This aligns the comparison with WeakMaps and WeakSets. Only reference equal promises will pass the check in the future.
Fixes #55198