stream: add brotli support to CompressionStream and DecompressionStream #59464

KhafraDev · 2025-08-13T22:15:52Z

It has shipped in Safari 18.4, I don't see a reason to hold off until the spec is written.

codecov · 2025-08-13T23:11:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.88%. Comparing base (9ec68af) to head (42dd5f6).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59464      +/-   ##
==========================================
- Coverage   89.88%   89.88%   -0.01%     
==========================================
  Files         656      664       +8     
  Lines      192967   194951    +1984     
  Branches    37848    38296     +448     
==========================================
+ Hits       173451   175232    +1781     
- Misses      12070    12184     +114     
- Partials     7446     7535      +89

Files with missing lines	Coverage Δ
lib/internal/webstreams/compression.js	`97.77% <100.00%> (+0.08%)`	⬆️

... and 91 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LiviaMedeiros

+1 on adding this, but is there a consensus if the format should be called brotli or br, or if one should be an alias for another?
If not, perhaps we should emit experimental warning for this.

github-actions · 2025-08-14T13:17:48Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @LiviaMedeiros.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

KhafraDev · 2025-08-14T13:43:56Z

Safari shipped as 'brotli'

github-actions · 2025-08-14T23:45:09Z

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/16979245607

Uzlopak

LGTM

KhafraDev · 2025-08-18T16:16:12Z

cc @nodejs/web-standards @nodejs/whatwg-stream

test/parallel/test-whatwg-webstreams-compression.js

Refs: whatwg/compression#34

nodejs-github-bot · 2025-08-20T19:56:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68774/

nodejs-github-bot · 2025-08-20T23:36:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68775/ 🔥

nodejs-github-bot · 2025-08-21T02:22:20Z

Landed in 44d9e6d

Refs: whatwg/compression#34 PR-URL: #59464 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>

Notable changes: crypto: * (SEMVER-MINOR) add AES-OCB Web Cryptography algorithm (Filip Skokan) #59539 * update root certificates to NSS 3.114 (Node.js GitHub Bot) #59571 * (SEMVER-MINOR) support ML-KEM in Web Cryptography (Filip Skokan) #59569 * (SEMVER-MINOR) support ML-KEM, DHKEM, and RSASVE key encapsulation mechanisms (Filip Skokan) #59491 * (SEMVER-MINOR) add argon2() and argon2Sync() methods (Ranieri Althoff) #50353 * (SEMVER-MINOR) support ML-DSA spki/pkcs8 key formats in Web Cryptography (Filip Skokan) #59365 * (SEMVER-MINOR) subject some algorithms in Web Cryptography on BoringSSL absence (Filip Skokan) #59365 * (SEMVER-MINOR) add ChaCha20-Poly1305 Web Cryptography algorithm (Filip Skokan) #59365 * (SEMVER-MINOR) add subtle.getPublicKey() utility function in Web Cryptography (Filip Skokan) #59365 * (SEMVER-MINOR) add SHA-3 Web Cryptography digest algorithms (Filip Skokan) #59365 * (SEMVER-MINOR) add SHAKE Web Cryptography digest algorithms (Filip Skokan) #59365 * (SEMVER-MINOR) add SubtleCrypto.supports feature detection in Web Cryptography (Filip Skokan) #59365 * (SEMVER-MINOR) support ML-DSA in Web Cryptography (Filip Skokan) #59365 * (SEMVER-MINOR) support ML-KEM KeyObject (Filip Skokan) #59461 doc: * (SEMVER-MINOR) compress Web Cryptography Algorithm matrix (Filip Skokan) #59365 http: * (SEMVER-MINOR) add Agent.agentKeepAliveTimeoutBuffer option (Haram Jeong) #59315 http2: * (SEMVER-MINOR) add support for raw header arrays in h2Stream.respond() (Tim Perry) #59455 lib: * (SEMVER-MINOR) refactor kSupportedAlgorithms (Filip Skokan) #59365 sea: * (SEMVER-MINOR) support execArgv in sea config (Joyee Cheung) #59314 stream: * (SEMVER-MINOR) add brotli support to CompressionStream and DecompressionStream (Matthew Aitken) #59464 test: * (SEMVER-MINOR) add Web Cryptography wrap/unwrap vectors (Filip Skokan) #59365 * (SEMVER-MINOR) cleanup test-webcrypto-supports (Filip Skokan) #59365 PR-URL: #59629

Notable changes: crypto: * update root certificates to NSS 3.114 (Node.js GitHub Bot) #59571 * (SEMVER-MINOR) add AES-OCB Web Cryptography algorithm (Filip Skokan) #59539 * (SEMVER-MINOR) support ML-KEM in Web Cryptography (Filip Skokan) #59569 * (SEMVER-MINOR) support ML-KEM, DHKEM, and RSASVE key encapsulation mechanisms (Filip Skokan) #59491 * (SEMVER-MINOR) add argon2() and argon2Sync() methods (Ranieri Althoff) #50353 * (SEMVER-MINOR) support ML-DSA spki/pkcs8 key formats in Web Cryptography (Filip Skokan) #59365 * (SEMVER-MINOR) add ChaCha20-Poly1305 Web Cryptography algorithm (Filip Skokan) #59365 * (SEMVER-MINOR) add subtle.getPublicKey() utility function in Web Cryptography (Filip Skokan) #59365 * (SEMVER-MINOR) add SHA-3 Web Cryptography digest algorithms (Filip Skokan) #59365 * (SEMVER-MINOR) add SHAKE Web Cryptography digest algorithms (Filip Skokan) #59365 * (SEMVER-MINOR) add SubtleCrypto.supports feature detection in Web Cryptography (Filip Skokan) #59365 * (SEMVER-MINOR) support ML-DSA in Web Cryptography (Filip Skokan) #59365 * (SEMVER-MINOR) support ML-KEM KeyObject (Filip Skokan) #59461 http: * (SEMVER-MINOR) add Agent.agentKeepAliveTimeoutBuffer option (Haram Jeong) #59315 http2: * (SEMVER-MINOR) add support for raw header arrays in h2Stream.respond() (Tim Perry) #59455 sea: * (SEMVER-MINOR) support execArgv in sea config (Joyee Cheung) #59314 stream: * (SEMVER-MINOR) add brotli support to CompressionStream and DecompressionStream (Matthew Aitken) #59464 PR-URL: #59629

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Aug 13, 2025

KhafraDev changed the title ~~Compressionstream brotli~~ stream: add brotli support to CompressionStream and DecompressionStream Aug 13, 2025

KhafraDev force-pushed the compressionstream-brotli branch from b170e35 to ea16859 Compare August 13, 2025 22:20

LiviaMedeiros reviewed Aug 14, 2025

View reviewed changes

LiviaMedeiros added semver-minor PRs that contain new features and should be released in the next minor version. notable-change PRs with changes that should be highlighted in changelogs. labels Aug 14, 2025

KhafraDev added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2025

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 14, 2025

KhafraDev added the review wanted PRs that need reviews. label Aug 15, 2025

Uzlopak approved these changes Aug 16, 2025

View reviewed changes

MattiasBuelens reviewed Aug 18, 2025

View reviewed changes

test/parallel/test-whatwg-webstreams-compression.js Outdated Show resolved Hide resolved

stream: add brotli support to CompressionStream and DecompressionStream

42dd5f6

Refs: whatwg/compression#34

KhafraDev force-pushed the compressionstream-brotli branch from ea16859 to 42dd5f6 Compare August 19, 2025 22:03

MattiasBuelens approved these changes Aug 20, 2025

View reviewed changes

jazelly approved these changes Aug 20, 2025

View reviewed changes

Ethan-Arrowood approved these changes Aug 20, 2025

View reviewed changes

KhafraDev added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Aug 20, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2025

KhafraDev added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2025

nodejs-github-bot merged commit 44d9e6d into nodejs:main Aug 21, 2025
60 checks passed

github-actions bot mentioned this pull request Aug 26, 2025

2025-08-27, Version 24.7.0 (Current) #59629

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

stream: add brotli support to CompressionStream and DecompressionStream #59464

stream: add brotli support to CompressionStream and DecompressionStream #59464

KhafraDev commented Aug 13, 2025

Uh oh!

codecov bot commented Aug 13, 2025 •

edited

Loading

Uh oh!

LiviaMedeiros left a comment

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

KhafraDev commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

Uzlopak left a comment

Uh oh!

KhafraDev commented Aug 18, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 20, 2025

Uh oh!

nodejs-github-bot commented Aug 20, 2025 •

edited by KhafraDev

Loading

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

stream: add brotli support to CompressionStream and DecompressionStream #59464

stream: add brotli support to CompressionStream and DecompressionStream #59464

Conversation

KhafraDev commented Aug 13, 2025

Uh oh!

codecov bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LiviaMedeiros left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

KhafraDev commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

Uzlopak left a comment

Choose a reason for hiding this comment

Uh oh!

KhafraDev commented Aug 18, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 20, 2025

Uh oh!

nodejs-github-bot commented Aug 20, 2025 • edited by KhafraDev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 21, 2025

Uh oh!

Uh oh!

codecov bot commented Aug 13, 2025 •

edited

Loading

nodejs-github-bot commented Aug 20, 2025 •

edited by KhafraDev

Loading