http, benchmark: remove CRLF variables #59466
Merged
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59466 +/- ##
==========================================
- Coverage 89.86% 89.77% -0.09%
==========================================
Files 656 654 -2
Lines 193141 192706 -435
Branches 37893 37746 -147
==========================================
- Hits 173561 172997 -564
- Misses 12103 12317 +214
+ Partials 7477 7392 -85 🚀 New features to boost your workflow:
|
marco-ippolito
approved these changes
Aug 14, 2025
ShogunPanda
approved these changes
Aug 14, 2025
pimterry
approved these changes
Aug 14, 2025
pimterry
added
request-ci
github-actions
bot
removed
the
request-ci
The |
richardlau
previously requested changes
Aug 14, 2025
richardlau
removed
the
author ready
Thanks for the review! Based on your feedback, I've added a commit to restore the |
RafaelGSS
approved these changes
Aug 15, 2025
richardlau
added
request-ci
github-actions
bot
removed
the
request-ci
wlgh1553
force-pushed
the
remove-crlf-variable
branch
from
eff20f7 to
080e9d3
Compare
|
This patch is needed for CI failures: 786431f. Please rebase onto the latest main to include it. |
wlgh1553
force-pushed
the
remove-crlf-variable
branch
from
080e9d3 to
871c9fc
Compare
github-actions
bot
removed
the
request-ci
bjohansebas
approved these changes
Aug 20, 2025
daeyeon
approved these changes
Aug 20, 2025
daeyeon
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ebbdea2 |
targos
pushed a commit
that referenced
this pull request
Aug 21, 2025
PR-URL: #59466 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces remaining usages of the
CRLFvariable with the string literal\r\nand removes theCRLFexport from_http_common.js.Background
In #40101, it was discussed that using the string literal
\r\nis clearer and more explicit than using aCRLFvariable. Based on this consensus, this PR replaces all remaining usages of theCRLFvariable with the\r\nliteral.About removing the export
Previously, there was a TODO comment not to remove the
CRLFexport from_http_common.jsbecause the module was considered "semi-public" and should not have breaking changes without proper deprecation (discussion).However, as of #59293, the
_http_common.jsmodule (along with othernode:_http_*modules) is now officially deprecated and considered internal-only:Given this, I considered it appropriate to remove the
CRLFexport.