Skip to content

benchmark: make child_process tests windows-compatible #59469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ri7116
Copy link
Contributor

@ri7116 ri7116 commented Aug 14, 2025

The spawn-echo and exec-stdout benchmarks fail on Windows due to use of Unix-specific commands.
Replace Unix-specific 'echo' command with 'cmd.exe /c echo' on Windows to ensure cross-platform compatibility.

The spawn-echo and exec-stdout benchmarks fail on Windows due to
use of Unix-specific commands.

Replace Unix-specific 'echo' command with 'cmd.exe /c echo'
on Windows to ensure cross-platform compatibility.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. child_process Issues and PRs related to the child_process subsystem. labels Aug 14, 2025
@richardlau
Copy link
Member

The spawn-echo and exec-stdout benchmarks fail on Windows due to use of Unix-specific commands. Replace Unix-specific 'echo' command with 'cmd.exe /c echo' on Windows to ensure cross-platform compatibility.

FWIW For Windows, we state in BUILDING.md that Unix tools are a pre-req for running tests:

node/BUILDING.md

Lines 647 to 649 in 91f035e

* Basic Unix tools required for some tests,
[Git for Windows](https://git-scm.com/download/win) includes Git Bash
and tools which can be included in the global `PATH`.

cc @nodejs/platform-windows

@StefanStojanovic
Copy link
Contributor

I agree with the previous comment. These changes are unnecessary as echo should be available on Windows if BUILDING.md is followed correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants