crypto: fix EVPKeyCtxPointer::publicCheck() #59471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 206ebeb added an additional call to EVP_PKEY_public_check and an unconditional return from publicCheck(). This prevents the control flow from reaching the original call to either EVP_PKEY_public_check or EVP_PKEY_public_check_quick. This change restores the previous behavior, which calls EVP_PKEY_public_check_quick instead, if possible. Refs: nodejs#56812
|
Review requested:
|
nodejs-github-bot
added
dependencies
tniessen
added
crypto
addaleax
approved these changes
Aug 14, 2025
panva
approved these changes
Aug 14, 2025
panva
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Aug 14, 2025
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ceaead7 |
panva
pushed a commit
to panva/node
that referenced
this pull request
Aug 18, 2025
Commit 206ebeb added an additional call to EVP_PKEY_public_check and an unconditional return from publicCheck(). This prevents the control flow from reaching the original call to either EVP_PKEY_public_check or EVP_PKEY_public_check_quick. This change restores the previous behavior, which calls EVP_PKEY_public_check_quick instead, if possible. Refs: nodejs#56812 PR-URL: nodejs#59471 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 206ebeb added an additional call to
EVP_PKEY_public_checkand an unconditional return frompublicCheck(). This prevents the control flow from reaching the original call to eitherEVP_PKEY_public_checkorEVP_PKEY_public_check_quick.This change restores the previous behavior, which calls
EVP_PKEY_public_check_quickinstead, if possible.Refs: #56812