cleaned up PWM rustdoc #523
Merged
+83
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #524 addresses future work. |
qwandor
reviewed
Jun 24, 2025
qwandor
reviewed
Jun 24, 2025
|
Thanks for the review and the catches! I have a couple of other things to document as well at this point: I'll push an update RSN. |
Hi, where did you get with this? |
|
Completely lost track of it ofc. Just rebased everything and took your review into account: should be ready to go I think. Thanks much for the ping. Apologies. |
qwandor
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PWM naming and usage is pretty confusing, and the Rustdoc does not clarify it. This is a bunch of doc changes to try to triage the situation. Should file an issue to maybe change the API, although at this late date not so likely probably.