Skip to content

Conversation

leosvelperez
Copy link
Member

Current Behavior

The bottom corner indicator of the in-progress section in the TUI is not displayed when there are more tasks in progress than the maximum parallel capacity (this can occur when there are continuous tasks).

Expected Behavior

The bottom corner indicator of the in-progress section in the TUI should always be displayed at the end of the running tasks.

@leosvelperez leosvelperez self-assigned this Oct 7, 2025
@leosvelperez leosvelperez requested review from a team as code owners October 7, 2025 09:16
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit c7ead7d
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/68e4da6cfd1573000824aeeb
😎 Deploy Preview https://deploy-preview-32985--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Oct 7, 2025 9:27am

Copy link
Contributor

nx-cloud bot commented Oct 7, 2025

View your CI Pipeline Execution ↗ for commit c7ead7d

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 5m 18s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 53s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-07 11:18:14 UTC

Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

The pull request modifies Rust code in the Nx TUI component (packages/nx/src/native/tui/components/tasks_list.rs) to fix a visual rendering bug where the bottom corner indicator is not displayed correctly. The change adjusts the separator calculation logic to account for scenarios where more tasks are in progress than the configured parallel limit.

All four failing e2e tests exhibit identical environmental failures during package installation:

  • e2e-angular fails with ERR_PNPM_FETCH_404 for lodash
  • e2e-esbuild tests fail with ERR_PNPM_FETCH_404 for glob-to-regexp and immutable
  • e2e-react fails with connection refused errors (cascading from setup failures)

These failures are categorized as 'environment_state' because:

  1. The local npm registry at localhost:4873 is failing to serve required packages
  2. The errors are network-related (ERR_PNPM_FETCH_404, "Not Found - 404")
  3. There is zero logical connection between Rust TUI rendering code changes and npm package resolution
  4. The PR only modifies visualization logic for the terminal interface
  5. These appear to be transient registry issues unrelated to any code changes

The test failures are caused by infrastructure issues with the local npm registry used for e2e testing, not by the code changes in this pull request. The changes to the TUI rendering logic are isolated to the Rust codebase and cannot affect package installation behavior.

A code change would likely not resolve this issue, so no action was taken.

Nx CloudView in Nx Cloud ↗


⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant