-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(core): display bottom corner indicator of tui in progress section correctly #32985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
View your CI Pipeline Execution ↗ for commit c7ead7d
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The pull request modifies Rust code in the Nx TUI component (packages/nx/src/native/tui/components/tasks_list.rs
) to fix a visual rendering bug where the bottom corner indicator is not displayed correctly. The change adjusts the separator calculation logic to account for scenarios where more tasks are in progress than the configured parallel limit.
All four failing e2e tests exhibit identical environmental failures during package installation:
e2e-angular
fails withERR_PNPM_FETCH_404
forlodash
e2e-esbuild
tests fail withERR_PNPM_FETCH_404
forglob-to-regexp
andimmutable
e2e-react
fails with connection refused errors (cascading from setup failures)
These failures are categorized as 'environment_state' because:
- The local npm registry at
localhost:4873
is failing to serve required packages - The errors are network-related (
ERR_PNPM_FETCH_404
, "Not Found - 404") - There is zero logical connection between Rust TUI rendering code changes and npm package resolution
- The PR only modifies visualization logic for the terminal interface
- These appear to be transient registry issues unrelated to any code changes
The test failures are caused by infrastructure issues with the local npm registry used for e2e testing, not by the code changes in this pull request. The changes to the TUI rendering logic are isolated to the Rust codebase and cannot affect package installation behavior.
A code change would likely not resolve this issue, so no action was taken.
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
Current Behavior
The bottom corner indicator of the in-progress section in the TUI is not displayed when there are more tasks in progress than the maximum parallel capacity (this can occur when there are continuous tasks).
Expected Behavior
The bottom corner indicator of the in-progress section in the TUI should always be displayed at the end of the running tasks.